Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eslint rule testing use jest (not mocha) #4328

Closed
zpao opened this issue Jul 9, 2015 · 1 comment
Closed

Make eslint rule testing use jest (not mocha) #4328

zpao opened this issue Jul 9, 2015 · 1 comment
Assignees
@bgw

Comments

@zpao
Copy link
Member

zpao commented Jul 9, 2015

using npm@3, mocha is not necessarily at node_modules/eslint-tester/node_modules/mocha/bin/mocha (thanks to hoisting). (eg it's actually at node_modules/mocha/bin/mocha for me)
@zpao zpao assigned bgw Jul 9, 2015
@bgw
Copy link
Contributor

bgw commented Jul 9, 2015

We've found out that it's possible to use eslint-tester with jest, so we should just do that.

@bgw bgw changed the title Make eslint rule testing more resiliant Make eslint rule testing use jest (not mocha) Jul 9, 2015
@zpao zpao mentioned this issue Jul 9, 2015
Merged
bgw added a commit to bgw/react that referenced this issue Jul 9, 2015
@bgw
Run eslint tests with jest
fc0b42d 
Turns out eslint-tester works with jest (!)

We take advantage of this internally at FB, so we'll do it here too.

Fixes facebook#4328
@bgw bgw mentioned this issue Jul 9, 2015
Merged
@zpao zpao closed this as completed in #4332 Jul 9, 2015
This was referenced Nov 30, 2023
Open
Open
Open
This was referenced Feb 11, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgw bgw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zpao @bgw