Enhance dev warnings for forwardRef render function (#13627) #13636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For 0 parameters: Do not warn because it may be due to usage of the arguments object. - For 1 parameter: Warn about missing the 'ref' parameter. - For 2 parameters: This is the ideal. Do not warn. - For more than 2 parameters: Warn about undefined parameters.
Details of bundled changes.Comparing: dde0645...5c832cc schedule
Generated by 🚫 dangerJS |
gaearon
reviewed
Sep 13, 2018
| return null; | ||
| } | ||
| it('should not warn if the render function provided does not use any parameter', () => { | ||
| const arityOfZero = () => null; |
There was a problem hiding this comment.
Can we make this more realistic? Such as a real pass through wrapper. Otherwise intent is not clear.
packages/react/src/forwardRef.js
Outdated
| 'forwardRef render functions accept exactly two parameters: props and ref. %s', | ||
| render.length === 1 | ||
| ? 'Did you forget to use the ref parameter?' | ||
| : 'Any additional parameter will be undefined', |
There was a problem hiding this comment.
Please add period to the sentence.
gaearon
approved these changes
Sep 13, 2018
|
Thanks |
|
Thank you! I am happy to contribute 😄 |
Merged
This was referenced Sep 14, 2018
Simek
pushed a commit
to Simek/react
that referenced
this pull request
Oct 25, 2018
…acebook#13636) * Enhance dev warnings for forwardRef render function - For 0 parameters: Do not warn because it may be due to usage of the arguments object. - For 1 parameter: Warn about missing the 'ref' parameter. - For 2 parameters: This is the ideal. Do not warn. - For more than 2 parameters: Warn about undefined parameters. * Make test cases for forwardRef warnings more realistic * Add period to warning sentence
This was referenced Nov 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…acebook#13636) * Enhance dev warnings for forwardRef render function - For 0 parameters: Do not warn because it may be due to usage of the arguments object. - For 1 parameter: Warn about missing the 'ref' parameter. - For 2 parameters: This is the ideal. Do not warn. - For more than 2 parameters: Warn about undefined parameters. * Make test cases for forwardRef warnings more realistic * Add period to warning sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arguments object.
Solves #13627