Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning code shows up in min build #1120

Closed
sophiebits opened this issue Feb 18, 2014 · 2 comments · Fixed by #1122
Closed

warning code shows up in min build #1120

sophiebits opened this issue Feb 18, 2014 · 2 comments · Fixed by #1122
Milestone

Comments

@sophiebits
Copy link
Contributor

See http://fb.me/react-0.9.0-rc1.min.js and search for "Invalid. We should either (a) change warning's implementation to warn only in __DEV__ and strip it in the build step or (b) change the callers to check __DEV__.

@cpojer?

@sophiebits sophiebits added this to the 0.9 milestone Feb 18, 2014
@sophiebits
Copy link
Contributor Author

(I think the functions that have the warnings aren't actually executed, but we should at least avoid including the warning message.)

@zpao
Copy link
Member

zpao commented Feb 18, 2014

I think we should just make warning look identical to invariant, then do the same thing we do in constants.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants