Skip to content

Commit

Permalink
Special case crossOrigin for SVG image elements (#14832)
Browse files Browse the repository at this point in the history
  • Loading branch information
aweary authored Feb 13, 2019
1 parent c6bee76 commit fa6205d
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions packages/react-dom/src/shared/DOMProperty.js
Original file line number Diff line number Diff line change
Expand Up @@ -525,13 +525,15 @@ const capitalize = token => token[1].toUpperCase();
);
});

// Special case: this attribute exists both in HTML and SVG.
// Its "tabindex" attribute name is case-sensitive in SVG so we can't just use
// its React `tabIndex` name, like we do for attributes that exist only in HTML.
properties.tabIndex = new PropertyInfoRecord(
'tabIndex',
STRING,
false, // mustUseProperty
'tabindex', // attributeName
null, // attributeNamespace
);
// These attribute exists both in HTML and SVG.
// The attribute name is case-sensitive in SVG so we can't just use
// the React name like we do for attributes that exist only in HTML.
['tabIndex', 'crossOrigin'].forEach(attributeName => {
properties[attributeName] = new PropertyInfoRecord(
attributeName,
STRING,
false, // mustUseProperty
attributeName.toLowerCase(), // attributeName
null, // attributeNamespace
);
});

0 comments on commit fa6205d

Please sign in to comment.