Apply suggestions from code review

Co-authored-by: Timothy Yung <yungsters@gmail.com>
facebook · Jun 10, 2024 · eb089cd · eb089cd
1 parent b683b3c
commit eb089cd
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/.github/workflows/commit_artifacts.yml b/.github/workflows/commit_artifacts.yml
@@ -389,7 +389,7 @@ jobs:
                 }
                 return data.replace(NEWTOKEN, `SignedSource<<${hash(data, 'utf8')}>>`);
               },
-             };
+            };
 
             const directory = './compiled-rn';
             console.log('Signing files in directory:', directory);
@@ -415,6 +415,7 @@ jobs:
                 });
               }
             } catch (e) {
+              process.exitCode = 1;
               console.error('Error signing files:', e);
             }
       - name: Check for changes
@@ -498,7 +499,7 @@ jobs:
                 }
                 return data.replace(NEWTOKEN, `SignedSource<<${hash(data, 'utf8')}>>`);
               },
-             };
+            };
 
             const directory = './compiled-rn';
             console.log('Signing files in directory:', directory);
@@ -524,6 +525,7 @@ jobs:
                 });
               }
             } catch (e) {
+              process.exitCode = 1;
               console.error('Error signing files:', e);
             }
       - name: Will commit these changes