Skip to content

Commit

Permalink
[Float] Suspend unstyled content for up to 1 minute (#26532)
Browse files Browse the repository at this point in the history
We almost never want to show content before its styles have loaded. But
eventually we will give up and allow unstyled content. So this extends
the timeout to a full minute. This somewhat arbitrary — big enough that
you'd only reach it under extreme circumstances.

Note that, like regular Suspense, the app is still interactive while
we're waiting for content to load. Only the unstyled content is blocked
from appearing, not updates in general. A new update will interrupt it.

We should figure out what the browser engines do during initial page
load and consider aligning our behavior with that. It's supposed to be
render blocking by default but there may be some cases where they, too,
give up and FOUC.

DiffTrain build for commit 0ae3480.
  • Loading branch information
acdlite committed Mar 31, 2023
1 parent a4a493a commit de3e5f9
Show file tree
Hide file tree
Showing 13 changed files with 19 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23869,7 +23869,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-next-888874673-20230331";
var ReactVersion = "18.3.0-next-0ae348018-20230331";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8674,7 +8674,7 @@ var devToolsConfig$jscomp$inline_1026 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-888874673-20230331",
version: "18.3.0-next-0ae348018-20230331",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1218 = {
Expand Down Expand Up @@ -8705,7 +8705,7 @@ var internals$jscomp$inline_1218 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-888874673-20230331"
reconcilerVersion: "18.3.0-next-0ae348018-20230331"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1219 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9099,7 +9099,7 @@ var devToolsConfig$jscomp$inline_1068 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-next-888874673-20230331",
version: "18.3.0-next-0ae348018-20230331",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1259 = {
Expand Down Expand Up @@ -9130,7 +9130,7 @@ var internals$jscomp$inline_1259 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-888874673-20230331"
reconcilerVersion: "18.3.0-next-0ae348018-20230331"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1260 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-next-888874673-20230331";
var ReactVersion = "18.3.0-next-0ae348018-20230331";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-888874673-20230331";
exports.version = "18.3.0-next-0ae348018-20230331";
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-next-888874673-20230331";
exports.version = "18.3.0-next-0ae348018-20230331";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
888874673f81c08d9c3cfd4a56e2e93fd728894c
0ae348018d5b3a3f1ccdd92de85d9cc581b2b98d
Original file line number Diff line number Diff line change
Expand Up @@ -27145,7 +27145,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-next-888874673-20230331";
var ReactVersion = "18.3.0-next-0ae348018-20230331";

function createPortal$1(
children,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9545,7 +9545,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1046 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-next-888874673-20230331",
version: "18.3.0-next-0ae348018-20230331",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -9587,7 +9587,7 @@ var internals$jscomp$inline_1291 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-888874673-20230331"
reconcilerVersion: "18.3.0-next-0ae348018-20230331"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1292 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10253,7 +10253,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1124 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-next-888874673-20230331",
version: "18.3.0-next-0ae348018-20230331",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -10308,7 +10308,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-888874673-20230331"
reconcilerVersion: "18.3.0-next-0ae348018-20230331"
});
exports.createPortal = function (children, containerTag) {
return createPortal$1(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27685,7 +27685,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-next-888874673-20230331";
var ReactVersion = "18.3.0-next-0ae348018-20230331";

function createPortal$1(
children,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9801,7 +9801,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1105 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-next-888874673-20230331",
version: "18.3.0-next-0ae348018-20230331",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -9843,7 +9843,7 @@ var internals$jscomp$inline_1357 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-888874673-20230331"
reconcilerVersion: "18.3.0-next-0ae348018-20230331"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1358 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10509,7 +10509,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1183 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-next-888874673-20230331",
version: "18.3.0-next-0ae348018-20230331",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForViewTag: function () {
Expand Down Expand Up @@ -10564,7 +10564,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-888874673-20230331"
reconcilerVersion: "18.3.0-next-0ae348018-20230331"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
computeComponentStackForErrorReporting: function (reactTag) {
Expand Down

0 comments on commit de3e5f9

Please sign in to comment.