Print stack in devtool exception warning (#6768)

(cherry picked from commit 5b5bd5e)
facebook · Jun 14, 2016 · 9483255 · 9483255
1 parent b3d37a9
commit 9483255
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/isomorphic/ReactDebugTool.js b/src/isomorphic/ReactDebugTool.js
@@ -31,7 +31,7 @@ function emitEvent(handlerFunctionName, arg1, arg2, arg3, arg4, arg5) {
           handlerDoesThrowForEvent[handlerFunctionName],
           'exception thrown by devtool while handling %s: %s',
           handlerFunctionName,
-          e.message
+          e + '\n' + e.stack
         );
         handlerDoesThrowForEvent[handlerFunctionName] = true;
       }

diff --git a/src/isomorphic/__tests__/ReactDebugTool-test.js b/src/isomorphic/__tests__/ReactDebugTool-test.js
@@ -66,7 +66,7 @@ describe('ReactDebugTool', function() {
     expect(console.error.calls.length).toBe(1);
     expect(console.error.argsForCall[0][0]).toContain(
       'exception thrown by devtool while handling ' +
-      'onTestEvent: Hi.'
+      'onTestEvent: Error: Hi.'
     );
 
     ReactDebugTool.onTestEvent();

diff --git a/src/renderers/dom/shared/ReactDOMDebugTool.js b/src/renderers/dom/shared/ReactDOMDebugTool.js
@@ -31,7 +31,7 @@ function emitEvent(handlerFunctionName, arg1, arg2, arg3, arg4, arg5) {
           handlerDoesThrowForEvent[handlerFunctionName],
           'exception thrown by devtool while handling %s: %s',
           handlerFunctionName,
-          e.message
+          e + '\n' + e.stack
         );
         handlerDoesThrowForEvent[handlerFunctionName] = true;
       }

diff --git a/src/renderers/dom/shared/__tests__/ReactDOMDebugTool-test.js b/src/renderers/dom/shared/__tests__/ReactDOMDebugTool-test.js
@@ -66,7 +66,7 @@ describe('ReactDOMDebugTool', function() {
     expect(console.error.calls.length).toBe(1);
     expect(console.error.argsForCall[0][0]).toContain(
       'exception thrown by devtool while handling ' +
-      'onTestEvent: Hi.'
+      'onTestEvent: Error: Hi.'
     );
 
     ReactDOMDebugTool.onTestEvent();