Remove unnecessary Update fields

packages/react-reconciler/src/ReactFiberClassComponent.new.js

@@ -199,7 +199,7 @@ const classComponentUpdater = {
     const suspenseConfig = requestCurrentSuspenseConfig();
     const lane = requestUpdateLane(fiber, suspenseConfig);
 
-    const update = createUpdate(eventTime, lane, suspenseConfig);
+    const update = createUpdate(eventTime, lane);
     update.payload = payload;
     if (callback !== undefined && callback !== null) {
       if (__DEV__) {
@@ -230,7 +230,7 @@ const classComponentUpdater = {
     const suspenseConfig = requestCurrentSuspenseConfig();
     const lane = requestUpdateLane(fiber, suspenseConfig);
 
-    const update = createUpdate(eventTime, lane, suspenseConfig);
+    const update = createUpdate(eventTime, lane);
     update.tag = ReplaceState;
     update.payload = payload;
 
@@ -263,7 +263,7 @@ const classComponentUpdater = {
     const suspenseConfig = requestCurrentSuspenseConfig();
     const lane = requestUpdateLane(fiber, suspenseConfig);
 
-    const update = createUpdate(eventTime, lane, suspenseConfig);
+    const update = createUpdate(eventTime, lane);
     update.tag = ForceUpdate;
 
     if (callback !== undefined && callback !== null) {

packages/react-reconciler/src/ReactFiberClassComponent.old.js

@@ -199,7 +199,7 @@ const classComponentUpdater = {
     const suspenseConfig = requestCurrentSuspenseConfig();
     const lane = requestUpdateLane(fiber, suspenseConfig);
 
-    const update = createUpdate(eventTime, lane, suspenseConfig);
+    const update = createUpdate(eventTime, lane);
     update.payload = payload;
     if (callback !== undefined && callback !== null) {
       if (__DEV__) {
@@ -230,7 +230,7 @@ const classComponentUpdater = {
     const suspenseConfig = requestCurrentSuspenseConfig();
     const lane = requestUpdateLane(fiber, suspenseConfig);
 
-    const update = createUpdate(eventTime, lane, suspenseConfig);
+    const update = createUpdate(eventTime, lane);
     update.tag = ReplaceState;
     update.payload = payload;
 
@@ -263,7 +263,7 @@ const classComponentUpdater = {
     const suspenseConfig = requestCurrentSuspenseConfig();
     const lane = requestUpdateLane(fiber, suspenseConfig);
 
-    const update = createUpdate(eventTime, lane, suspenseConfig);
+    const update = createUpdate(eventTime, lane);
     update.tag = ForceUpdate;
 
     if (callback !== undefined && callback !== null) {

packages/react-reconciler/src/ReactFiberHooks.new.js

@@ -96,11 +96,7 @@ import {markStateUpdateScheduled} from './SchedulingProfiler';
 const {ReactCurrentDispatcher, ReactCurrentBatchConfig} = ReactSharedInternals;
 
 type Update<S, A> = {|
-  // TODO: Temporary field. Will remove this by storing a map of
-  // transition -> start time on the root.
-  eventTime: number,
   lane: Lane,
-  suspenseConfig: null | SuspenseConfig,
   action: A,
   eagerReducer: ((S, A) => S) | null,
   eagerState: S | null,
@@ -714,17 +710,13 @@ function updateReducer<S, I, A>(
     let newBaseQueueLast = null;
     let update = first;
     do {
-      const suspenseConfig = update.suspenseConfig;
       const updateLane = update.lane;
-      const updateEventTime = update.eventTime;
       if (!isSubsetOfLanes(renderLanes, updateLane)) {
         // Priority is insufficient. Skip this update. If this is the first
         // skipped update, the previous update/state is the new base
         // update/state.
         const clone: Update<S, A> = {
-          eventTime: updateEventTime,
           lane: updateLane,
-          suspenseConfig: suspenseConfig,
           action: update.action,
           eagerReducer: update.eagerReducer,
           eagerState: update.eagerState,
@@ -749,12 +741,10 @@ function updateReducer<S, I, A>(
 
         if (newBaseQueueLast !== null) {
           const clone: Update<S, A> = {
-            eventTime: updateEventTime,
             // This update is going to be committed so we never want uncommit
             // it. Using NoLane works because 0 is a subset of all bitmasks, so
             // this will never be skipped by the check above.
             lane: NoLane,
-            suspenseConfig: update.suspenseConfig,
             action: update.action,
             eagerReducer: update.eagerReducer,
             eagerState: update.eagerState,
@@ -1699,9 +1689,7 @@ function dispatchAction<S, A>(
   const lane = requestUpdateLane(fiber, suspenseConfig);
 
   const update: Update<S, A> = {
-    eventTime,
     lane,
-    suspenseConfig,
     action,
     eagerReducer: null,
     eagerState: null,

packages/react-reconciler/src/ReactFiberHooks.old.js

@@ -95,11 +95,7 @@ import {markStateUpdateScheduled} from './SchedulingProfiler';
 const {ReactCurrentDispatcher, ReactCurrentBatchConfig} = ReactSharedInternals;
 
 type Update<S, A> = {|
-  // TODO: Temporary field. Will remove this by storing a map of
-  // transition -> start time on the root.
-  eventTime: number,
   lane: Lane,
-  suspenseConfig: null | SuspenseConfig,
   action: A,
   eagerReducer: ((S, A) => S) | null,
   eagerState: S | null,
@@ -713,17 +709,13 @@ function updateReducer<S, I, A>(
     let newBaseQueueLast = null;
     let update = first;
     do {
-      const suspenseConfig = update.suspenseConfig;
       const updateLane = update.lane;
-      const updateEventTime = update.eventTime;
       if (!isSubsetOfLanes(renderLanes, updateLane)) {
         // Priority is insufficient. Skip this update. If this is the first
         // skipped update, the previous update/state is the new base
         // update/state.
         const clone: Update<S, A> = {
-          eventTime: updateEventTime,
           lane: updateLane,
-          suspenseConfig: suspenseConfig,
           action: update.action,
           eagerReducer: update.eagerReducer,
           eagerState: update.eagerState,
@@ -748,12 +740,10 @@ function updateReducer<S, I, A>(
 
         if (newBaseQueueLast !== null) {
           const clone: Update<S, A> = {
-            eventTime: updateEventTime,
             // This update is going to be committed so we never want uncommit
             // it. Using NoLane works because 0 is a subset of all bitmasks, so
             // this will never be skipped by the check above.
             lane: NoLane,
-            suspenseConfig: update.suspenseConfig,
             action: update.action,
             eagerReducer: update.eagerReducer,
             eagerState: update.eagerState,
@@ -1697,9 +1687,7 @@ function dispatchAction<S, A>(
   const lane = requestUpdateLane(fiber, suspenseConfig);
 
   const update: Update<S, A> = {
-    eventTime,
     lane,
-    suspenseConfig,
     action,
     eagerReducer: null,
     eagerState: null,

packages/react-reconciler/src/ReactFiberNewContext.new.js

@@ -212,7 +212,6 @@ export function propagateContextChange(
             const update = createUpdate(
               NoTimestamp,
               pickArbitraryLane(renderLanes),
-              null,
             );
             update.tag = ForceUpdate;
             // TODO: Because we don't have a work-in-progress, this will add the

packages/react-reconciler/src/ReactFiberNewContext.old.js

@@ -212,7 +212,6 @@ export function propagateContextChange(
             const update = createUpdate(
               NoTimestamp,
               pickArbitraryLane(renderLanes),
-              null,
             );
             update.tag = ForceUpdate;
             // TODO: Because we don't have a work-in-progress, this will add the

packages/react-reconciler/src/ReactFiberReconciler.new.js

@@ -297,7 +297,7 @@ export function updateContainer(
     }
   }
 
-  const update = createUpdate(eventTime, lane, suspenseConfig);
+  const update = createUpdate(eventTime, lane);
   // Caution: React DevTools currently depends on this property
   // being called "element".
   update.payload = {element};

packages/react-reconciler/src/ReactFiberReconciler.old.js

@@ -297,7 +297,7 @@ export function updateContainer(
     }
   }
 
-  const update = createUpdate(eventTime, lane, suspenseConfig);
+  const update = createUpdate(eventTime, lane);
   // Caution: React DevTools currently depends on this property
   // being called "element".
   update.payload = {element};

packages/react-reconciler/src/ReactFiberThrow.new.js

@@ -76,7 +76,7 @@ function createRootErrorUpdate(
   errorInfo: CapturedValue<mixed>,
   lane: Lane,
 ): Update<mixed> {
-  const update = createUpdate(NoTimestamp, lane, null);
+  const update = createUpdate(NoTimestamp, lane);
   // Unmount the root by rendering null.
   update.tag = CaptureUpdate;
   // Caution: React DevTools currently depends on this property
@@ -95,7 +95,7 @@ function createClassErrorUpdate(
   errorInfo: CapturedValue<mixed>,
   lane: Lane,
 ): Update<mixed> {
-  const update = createUpdate(NoTimestamp, lane, null);
+  const update = createUpdate(NoTimestamp, lane);
   update.tag = CaptureUpdate;
   const getDerivedStateFromError = fiber.type.getDerivedStateFromError;
   if (typeof getDerivedStateFromError === 'function') {
@@ -274,7 +274,7 @@ function throwException(
               // When we try rendering again, we should not reuse the current fiber,
               // since it's known to be in an inconsistent state. Use a force update to
               // prevent a bail out.
-              const update = createUpdate(NoTimestamp, SyncLane, null);
+              const update = createUpdate(NoTimestamp, SyncLane);
               update.tag = ForceUpdate;
               enqueueUpdate(sourceFiber, update);
             }

packages/react-reconciler/src/ReactFiberThrow.old.js

@@ -76,7 +76,7 @@ function createRootErrorUpdate(
   errorInfo: CapturedValue<mixed>,
   lane: Lane,
 ): Update<mixed> {
-  const update = createUpdate(NoTimestamp, lane, null);
+  const update = createUpdate(NoTimestamp, lane);
   // Unmount the root by rendering null.
   update.tag = CaptureUpdate;
   // Caution: React DevTools currently depends on this property
@@ -95,7 +95,7 @@ function createClassErrorUpdate(
   errorInfo: CapturedValue<mixed>,
   lane: Lane,
 ): Update<mixed> {
-  const update = createUpdate(NoTimestamp, lane, null);
+  const update = createUpdate(NoTimestamp, lane);
   update.tag = CaptureUpdate;
   const getDerivedStateFromError = fiber.type.getDerivedStateFromError;
   if (typeof getDerivedStateFromError === 'function') {
@@ -276,7 +276,7 @@ function throwException(
               // When we try rendering again, we should not reuse the current fiber,
               // since it's known to be in an inconsistent state. Use a force update to
               // prevent a bail out.
-              const update = createUpdate(NoTimestamp, SyncLane, null);
+              const update = createUpdate(NoTimestamp, SyncLane);
               update.tag = ForceUpdate;
               enqueueUpdate(sourceFiber, update);
             }

packages/react-reconciler/src/ReactUpdateQueue.new.js

@@ -86,7 +86,6 @@
 
 import type {Fiber} from './ReactInternalTypes';
 import type {Lanes, Lane} from './ReactFiberLane';
-import type {SuspenseConfig} from './ReactFiberSuspenseConfig';
 
 import {NoLane, NoLanes, isSubsetOfLanes, mergeLanes} from './ReactFiberLane';
 import {
@@ -109,7 +108,6 @@ export type Update<State> = {|
   // transition -> event time on the root.
   eventTime: number,
   lane: Lane,
-  suspenseConfig: null | SuspenseConfig,
 
   tag: 0 | 1 | 2 | 3,
   payload: any,
@@ -183,15 +181,10 @@ export function cloneUpdateQueue<State>(
   }
 }
 
-export function createUpdate(
-  eventTime: number,
-  lane: Lane,
-  suspenseConfig: null | SuspenseConfig,
-): Update<*> {
+export function createUpdate(eventTime: number, lane: Lane): Update<*> {
   const update: Update<*> = {
     eventTime,
     lane,
-    suspenseConfig,
 
     tag: UpdateState,
     payload: null,
@@ -266,7 +259,6 @@ export function enqueueCapturedUpdate<State>(
           const clone: Update<State> = {
             eventTime: update.eventTime,
             lane: update.lane,
-            suspenseConfig: update.suspenseConfig,
 
             tag: update.tag,
             payload: update.payload,
@@ -479,7 +471,6 @@ export function processUpdateQueue<State>(
         const clone: Update<State> = {
           eventTime: updateEventTime,
           lane: updateLane,
-          suspenseConfig: update.suspenseConfig,
 
           tag: update.tag,
           payload: update.payload,
@@ -505,7 +496,6 @@ export function processUpdateQueue<State>(
             // it. Using NoLane works because 0 is a subset of all bitmasks, so
             // this will never be skipped by the check above.
             lane: NoLane,
-            suspenseConfig: update.suspenseConfig,
 
             tag: update.tag,
             payload: update.payload,

packages/react-reconciler/src/ReactUpdateQueue.old.js

@@ -86,7 +86,6 @@
 
 import type {Fiber} from './ReactInternalTypes';
 import type {Lanes, Lane} from './ReactFiberLane';
-import type {SuspenseConfig} from './ReactFiberSuspenseConfig';
 
 import {NoLane, NoLanes, isSubsetOfLanes, mergeLanes} from './ReactFiberLane';
 import {
@@ -109,7 +108,6 @@ export type Update<State> = {|
   // transition -> event time on the root.
   eventTime: number,
   lane: Lane,
-  suspenseConfig: null | SuspenseConfig,
 
   tag: 0 | 1 | 2 | 3,
   payload: any,
@@ -183,15 +181,10 @@ export function cloneUpdateQueue<State>(
   }
 }
 
-export function createUpdate(
-  eventTime: number,
-  lane: Lane,
-  suspenseConfig: null | SuspenseConfig,
-): Update<*> {
+export function createUpdate(eventTime: number, lane: Lane): Update<*> {
   const update: Update<*> = {
     eventTime,
     lane,
-    suspenseConfig,
 
     tag: UpdateState,
     payload: null,
@@ -266,7 +259,6 @@ export function enqueueCapturedUpdate<State>(
           const clone: Update<State> = {
             eventTime: update.eventTime,
             lane: update.lane,
-            suspenseConfig: update.suspenseConfig,
 
             tag: update.tag,
             payload: update.payload,
@@ -479,7 +471,6 @@ export function processUpdateQueue<State>(
         const clone: Update<State> = {
           eventTime: updateEventTime,
           lane: updateLane,
-          suspenseConfig: update.suspenseConfig,
 
           tag: update.tag,
           payload: update.payload,
@@ -505,7 +496,6 @@ export function processUpdateQueue<State>(
             // it. Using NoLane works because 0 is a subset of all bitmasks, so
             // this will never be skipped by the check above.
             lane: NoLane,
-            suspenseConfig: update.suspenseConfig,
 
             tag: update.tag,
             payload: update.payload,