Skip to content

Commit

Permalink
Reland #28672: Remove IndeterminateComponent (#28681)
Browse files Browse the repository at this point in the history
This PR relands #28672 on top of the flag removal and the test
demonstrating a breakage in Suspense for legacy mode.

React has deprecated module pattern Function Components for many years
at this point. Supporting this pattern required React to have a concept
of an indeterminate component so that when a component first renders it
can turn into either a ClassComponent or a FunctionComponent depending
on what it returns. While this feature was deprecated and put behind a
flag it is still in stable. This change remvoes the flag, removes the
warnings, and removes the concept of IndeterminateComponent from the
React codebase.

While removing IndeterminateComponent type Seb and I discovered that we
needed a concept of IncompleteFunctionComponent to support Suspense in
legacy mode. This new work tag is only needed as long as legacy mode is
around and ideally any code that considers this tag will be excludable
from OSS builds once we land extra gates using `disableLegacyMode` flag.

DiffTrain build for commit 5998a77.
  • Loading branch information
gnoff committed Apr 3, 2024
1 parent 94f98fd commit 6d2deb7
Show file tree
Hide file tree
Showing 10 changed files with 1,870 additions and 2,155 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
8cb6a1c0347a69ad4c580c5cf5f28d8be544d6d4
5998a775194f491afa5d3badd9afe9ceaf12845e
Loading

0 comments on commit 6d2deb7

Please sign in to comment.