Skip to content

Commit

Permalink
Replace zero with NoLanes for consistency in FiberLane (#24327)
Browse files Browse the repository at this point in the history
  • Loading branch information
wtlin1228 authored and rickhanlonii committed Apr 14, 2022
1 parent f2436ab commit 678606d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions packages/react-reconciler/src/ReactFiberLane.new.js
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ export function includesExpiredLane(root: FiberRoot, lanes: Lanes) {
}

export function isTransitionLane(lane: Lane) {
return (lane & TransitionLanes) !== 0;
return (lane & TransitionLanes) !== NoLanes;
}

export function claimNextTransitionLane(): Lane {
Expand All @@ -492,7 +492,7 @@ export function claimNextTransitionLane(): Lane {
// run out of lanes and cycle back to the beginning.
const lane = nextTransitionLane;
nextTransitionLane <<= 1;
if ((nextTransitionLane & TransitionLanes) === 0) {
if ((nextTransitionLane & TransitionLanes) === NoLanes) {
nextTransitionLane = TransitionLane1;
}
return lane;
Expand All @@ -501,7 +501,7 @@ export function claimNextTransitionLane(): Lane {
export function claimNextRetryLane(): Lane {
const lane = nextRetryLane;
nextRetryLane <<= 1;
if ((nextRetryLane & RetryLanes) === 0) {
if ((nextRetryLane & RetryLanes) === NoLanes) {
nextRetryLane = RetryLane1;
}
return lane;
Expand Down Expand Up @@ -634,8 +634,8 @@ export function markRootFinished(root: FiberRoot, remainingLanes: Lanes) {
root.pendingLanes = remainingLanes;

// Let's try everything again
root.suspendedLanes = 0;
root.pingedLanes = 0;
root.suspendedLanes = NoLanes;
root.pingedLanes = NoLanes;

root.expiredLanes &= remainingLanes;
root.mutableReadLanes &= remainingLanes;
Expand Down
10 changes: 5 additions & 5 deletions packages/react-reconciler/src/ReactFiberLane.old.js
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ export function includesExpiredLane(root: FiberRoot, lanes: Lanes) {
}

export function isTransitionLane(lane: Lane) {
return (lane & TransitionLanes) !== 0;
return (lane & TransitionLanes) !== NoLanes;
}

export function claimNextTransitionLane(): Lane {
Expand All @@ -492,7 +492,7 @@ export function claimNextTransitionLane(): Lane {
// run out of lanes and cycle back to the beginning.
const lane = nextTransitionLane;
nextTransitionLane <<= 1;
if ((nextTransitionLane & TransitionLanes) === 0) {
if ((nextTransitionLane & TransitionLanes) === NoLanes) {
nextTransitionLane = TransitionLane1;
}
return lane;
Expand All @@ -501,7 +501,7 @@ export function claimNextTransitionLane(): Lane {
export function claimNextRetryLane(): Lane {
const lane = nextRetryLane;
nextRetryLane <<= 1;
if ((nextRetryLane & RetryLanes) === 0) {
if ((nextRetryLane & RetryLanes) === NoLanes) {
nextRetryLane = RetryLane1;
}
return lane;
Expand Down Expand Up @@ -634,8 +634,8 @@ export function markRootFinished(root: FiberRoot, remainingLanes: Lanes) {
root.pendingLanes = remainingLanes;

// Let's try everything again
root.suspendedLanes = 0;
root.pingedLanes = 0;
root.suspendedLanes = NoLanes;
root.pingedLanes = NoLanes;

root.expiredLanes &= remainingLanes;
root.mutableReadLanes &= remainingLanes;
Expand Down

0 comments on commit 678606d

Please sign in to comment.