Add expiration to fuzz tester

facebook · Oct 5, 2017 · 564c7e9 · 564c7e9
1 parent 320d71d
commit 564c7e9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/renderers/shared/fiber/ReactFiberBeginWork.js b/src/renderers/shared/fiber/ReactFiberBeginWork.js
@@ -330,7 +330,6 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
   }
 
   function updateHostRoot(current, workInProgress, renderExpirationTime) {
-    const root = (workInProgress.stateNode: FiberRoot);
     pushHostRootContext(workInProgress);
     const updateQueue = workInProgress.updateQueue;
     if (updateQueue !== null) {

diff --git a/src/renderers/shared/fiber/__tests__/ReactIncrementalTriangle-test.js b/src/renderers/shared/fiber/__tests__/ReactIncrementalTriangle-test.js
@@ -54,6 +54,14 @@ describe('ReactIncrementalTriangle', () => {
     };
   }
 
+  const EXPIRE = 'EXPIRE';
+  function expire(ms) {
+    return {
+      type: EXPIRE,
+      ms,
+    };
+  }
+
   function TriangleSimulator() {
     let triangles = [];
     let leafTriangles = [];
@@ -212,6 +220,9 @@ describe('ReactIncrementalTriangle', () => {
                 targetTriangle.activate();
               }
               break;
+            case EXPIRE:
+              ReactNoop.expire(action.ms);
+              break;
             default:
               break;
           }
@@ -251,7 +262,7 @@ describe('ReactIncrementalTriangle', () => {
     }
 
     function randomAction() {
-      switch (randomInteger(0, 4)) {
+      switch (randomInteger(0, 5)) {
         case 0:
           return flush(randomInteger(0, totalTriangles * 1.5));
         case 1:
@@ -260,6 +271,8 @@ describe('ReactIncrementalTriangle', () => {
           return interrupt();
         case 3:
           return toggle(randomInteger(0, totalChildren));
+        case 4:
+          return expire(randomInteger(0, 1500));
         default:
           throw new Error('Switch statement should be exhaustive');
       }
@@ -290,6 +303,9 @@ describe('ReactIncrementalTriangle', () => {
           case TOGGLE:
             result += `toggle(${action.childIndex})`;
             break;
+          case EXPIRE:
+            result += `expire(${action.ms})`;
+            break;
           default:
             throw new Error('Switch statement should be exhaustive');
         }