-
Notifications
You must be signed in to change notification settings - Fork 47.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test for unmount/remount in a single batch (#8470)
Fails in Fiber.
- Loading branch information
1 parent
df9dc89
commit 361ce5c
Showing
2 changed files
with
11 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
361ce5c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey man! fiber is developed under TDD right? Are those test in this repo(fiber) already OK?
361ce5c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular test is currently failing in Fiber.
You can read about how we develop Fiber in this thread:
https://twitter.com/dan_abramov/status/802142331818414080
https://twitter.com/dan_abramov/status/802142524232044544
https://twitter.com/dan_abramov/status/802142657640361985
https://twitter.com/dan_abramov/status/802142838427422720
https://twitter.com/dan_abramov/status/802143040282460160
361ce5c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man you are awesome:beer:
361ce5c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Facebook is already done with the fiber test right?
361ce5c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean—there's still quite a bit of work to do.
#7925