Run componentStorage outside the Flight bottom-frame

Otherwise we end up with another stack frame inside of it.
facebook · Jul 24, 2024 · 35dcda8 · 35dcda8
1 parent 8fc04fc
commit 35dcda8
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 53 deletions.
diff --git a/packages/react-server/src/ReactFlightCallUserSpace.js b/packages/react-server/src/ReactFlightCallUserSpace.js
@@ -15,13 +15,6 @@ import type {ReactClientValue} from './ReactFlightServer';
 
 import {setCurrentOwner} from './flight/ReactFlightCurrentOwner';
 
-import {
-  supportsComponentStorage,
-  componentStorage,
-} from './ReactFlightServerConfig';
-
-import {enableOwnerStacks} from 'shared/ReactFeatureFlags';
-
 // These indirections exists so we can exclude its stack frame in DEV (and anything below it).
 // TODO: Consider marking the whole bundle instead of these boundaries.
 
@@ -30,38 +23,12 @@ const callComponent = {
     Component: (p: Props, arg: void) => R,
     props: Props,
     componentDebugInfo: ReactComponentInfo,
-    debugTask: null | ConsoleTask,
   ): R {
     // The secondArg is always undefined in Server Components since refs error early.
     const secondArg = undefined;
     setCurrentOwner(componentDebugInfo);
     try {
-      if (supportsComponentStorage) {
-        // Run the component in an Async Context that tracks the current owner.
-        if (enableOwnerStacks && debugTask) {
-          return debugTask.run(
-            // $FlowFixMe[method-unbinding]
-            componentStorage.run.bind(
-              componentStorage,
-              componentDebugInfo,
-              Component,
-              props,
-              secondArg,
-            ),
-          );
-        }
-        return componentStorage.run(
-          componentDebugInfo,
-          Component,
-          props,
-          secondArg,
-        );
-      } else {
-        if (enableOwnerStacks && debugTask) {
-          return debugTask.run(Component.bind(null, props, secondArg));
-        }
-        return Component(props, secondArg);
-      }
+      return Component(props, secondArg);
     } finally {
       setCurrentOwner(null);
     }
@@ -72,7 +39,6 @@ export const callComponentInDEV: <Props, R>(
   Component: (p: Props, arg: void) => R,
   props: Props,
   componentDebugInfo: ReactComponentInfo,
-  debugTask: null | ConsoleTask,
 ) => R = __DEV__
   ? // We use this technique to trick minifiers to preserve the function name.
     (callComponent['react-stack-bottom-frame'].bind(callComponent): any)

diff --git a/packages/react-server/src/ReactFlightServer.js b/packages/react-server/src/ReactFlightServer.js
@@ -80,6 +80,8 @@ import {
   createHints,
   initAsyncDebugInfo,
   parseStackTrace,
+  supportsComponentStorage,
+  componentStorage,
 } from './ReactFlightServerConfig';
 
 import {
@@ -1035,12 +1037,38 @@ function renderFunctionComponent<Props>(
       }
     }
     prepareToUseHooksForComponent(prevThenableState, componentDebugInfo);
-    result = callComponentInDEV(
-      Component,
-      props,
-      componentDebugInfo,
-      task.debugTask,
-    );
+    if (supportsComponentStorage) {
+      // Run the component in an Async Context that tracks the current owner.
+      if (enableOwnerStacks && task.debugTask) {
+        result = task.debugTask.run(
+          // $FlowFixMe[method-unbinding]
+          componentStorage.run.bind(
+            componentStorage,
+            componentDebugInfo,
+            callComponentInDEV,
+            Component,
+            props,
+            componentDebugInfo,
+          ),
+        );
+      } else {
+        result = componentStorage.run(
+          componentDebugInfo,
+          callComponentInDEV,
+          Component,
+          props,
+          componentDebugInfo,
+        );
+      }
+    } else {
+      if (enableOwnerStacks && task.debugTask) {
+        result = task.debugTask.run(
+          callComponentInDEV.bind(null, Component, props, componentDebugInfo),
+        );
+      } else {
+        result = callComponentInDEV(Component, props, componentDebugInfo);
+      }
+    }
   } else {
     prepareToUseHooksForComponent(prevThenableState, null);
     // The secondArg is always undefined in Server Components since refs error early.
@@ -1222,19 +1250,47 @@ function warnForMissingKey(
 
     // Call with the server component as the currently rendering component
     // for context.
-    callComponentInDEV(
-      () => {
-        console.error(
-          'Each child in a list should have a unique "key" prop.' +
-            '%s%s See https://react.dev/link/warning-keys for more information.',
-          '',
-          '',
+    const logKeyError = () => {
+      console.error(
+        'Each child in a list should have a unique "key" prop.' +
+          '%s%s See https://react.dev/link/warning-keys for more information.',
+        '',
+        '',
+      );
+    };
+
+    if (supportsComponentStorage) {
+      // Run the component in an Async Context that tracks the current owner.
+      if (enableOwnerStacks && debugTask) {
+        debugTask.run(
+          // $FlowFixMe[method-unbinding]
+          componentStorage.run.bind(
+            componentStorage,
+            componentDebugInfo,
+            callComponentInDEV,
+            logKeyError,
+            null,
+            componentDebugInfo,
+          ),
         );
-      },
-      null,
-      componentDebugInfo,
-      debugTask,
-    );
+      } else {
+        componentStorage.run(
+          componentDebugInfo,
+          callComponentInDEV,
+          logKeyError,
+          null,
+          componentDebugInfo,
+        );
+      }
+    } else {
+      if (enableOwnerStacks && debugTask) {
+        debugTask.run(
+          callComponentInDEV.bind(null, logKeyError, null, componentDebugInfo),
+        );
+      } else {
+        callComponentInDEV(logKeyError, null, componentDebugInfo);
+      }
+    }
   }
 }