Profiler tooltip shows self duration (#18510)

facebook · Apr 6, 2020 · 3498f13 · 3498f13
1 parent c781156
commit 3498f13
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/packages/react-devtools-shared/src/devtools/views/Profiler/HoveredFiberInfo.css b/packages/react-devtools-shared/src/devtools/views/Profiler/HoveredFiberInfo.css
@@ -27,7 +27,7 @@
 }
 
 .CurrentCommit {
-  margin-top: 0.25rem;
+  margin: 0.25rem 0;
   display: block;
   width: 100%;
   text-align: left;

diff --git a/packages/react-devtools-shared/src/devtools/views/Profiler/HoveredFiberInfo.js b/packages/react-devtools-shared/src/devtools/views/Profiler/HoveredFiberInfo.js
@@ -10,7 +10,7 @@
 import * as React from 'react';
 import {Fragment, useContext} from 'react';
 import {ProfilerContext} from './ProfilerContext';
-import {formatDuration, formatTime} from './utils';
+import {formatDuration} from './utils';
 import WhatChanged from './WhatChanged';
 import {StoreContext} from '../context';
 
@@ -44,18 +44,17 @@ export default function HoveredFiberInfo({fiberData}: Props) {
   for (i = 0; i < commitIndices.length; i++) {
     const commitIndex = commitIndices[i];
     if (selectedCommitIndex === commitIndex) {
-      const {duration, timestamp} = profilerStore.getCommitData(
-        ((rootID: any): number),
-        commitIndex,
-      );
+      const {
+        fiberActualDurations,
+        fiberSelfDurations,
+      } = profilerStore.getCommitData(((rootID: any): number), commitIndex);
+      const actualDuration = fiberActualDurations.get(id) || 0;
+      const selfDuration = fiberSelfDurations.get(id) || 0;
 
       renderDurationInfo = (
-        <Fragment>
-          <label className={styles.Label}>Rendered at:</label>
-          <div key={commitIndex} className={styles.CurrentCommit}>
-            {formatTime(timestamp)}s for {formatDuration(duration)}ms
-          </div>
-        </Fragment>
+        <div key={commitIndex} className={styles.CurrentCommit}>
+          {formatDuration(selfDuration)}ms of {formatDuration(actualDuration)}ms
+        </div>
       );
 
       break;
@@ -68,10 +67,10 @@ export default function HoveredFiberInfo({fiberData}: Props) {
         <div className={styles.Component}>{name}</div>
       </div>
       <div className={styles.Content}>
-        <WhatChanged fiberID={((id: any): number)} />
         {renderDurationInfo || (
           <div>Did not render during this profiling session.</div>
         )}
+        <WhatChanged fiberID={((id: any): number)} />
       </div>
     </Fragment>
   );