Skip to content

Commit

Permalink
Removed version check
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Vaughn committed Nov 17, 2018
1 parent 200f17b commit 26001f6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"testRegex": "/scripts/jest/dont-run-jest-directly\\.js$"
},
"scripts": {
"build": "npm run version-check && node ./scripts/rollup/build.js",
"build": "node ./scripts/rollup/build.js",
"linc": "node ./scripts/tasks/linc.js",
"lint": "node ./scripts/tasks/eslint.js",
"lint-build": "node ./scripts/rollup/validate/index.js",
Expand Down
10 changes: 1 addition & 9 deletions scripts/release/create-canary-commands/build-artifacts.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,7 @@ const run = async ({cwd, dry, tempDirectory}) => {
};

await exec('yarn install', defaultOptions);

// We run rollup directly to avoid the version check.
// It's expected that canary package version and renderer version mismatch.
// Canaries version numbers use the format of 0.0.0-<sha> to be easily recognized (e.g. 0.0.0-57239eac8).
// A separate "React version" is used for the embedded renderer version to support DevTools,
// since it needs to distinguish between different version ranges of React.
// It is based on the version of React in the local package.json (e.g. 16.6.1-canary-57239eac8).
// Both numbers will be replaced if the canary is promoted to a stable release.
await exec('node ./scripts/rollup/build.js --extract-errors', defaultOptions);
await exec('yarn build -- --extract-errors', defaultOptions);

const tempNodeModulesPath = join(tempDirectory, 'build', 'node_modules');
const buildPath = join(cwd, 'build');
Expand Down

0 comments on commit 26001f6

Please sign in to comment.