[PushNotificationsIOS] registration error event #9650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @nicklockwood and @JAStanton to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
|
@nevir updated the pull request - view changes |
|
@nevir updated the pull request - view changes |
|
@nevir updated the pull request - view changes |
ghost
added
the
CLA Signed
|
@nevir updated the pull request - view changes |
ghost
added
the
CLA Signed
| # pragma mark - Push Notifications | ||
|
|
||
| // Required to register for notifications | ||
| - (void)application:(UIApplication *)__unused application didRegisterUserNotificationSettings:(UIUserNotificationSettings *)notificationSettings |
There was a problem hiding this comment.
Please format like application:(__unused UIApplication *)application didRegister...
|
Looks good, just a couple of small nits |
|
@javache updated (and rebased); thanks for the review! |
|
@nevir updated the pull request - view changes |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Sep 14, 2016
Summary: This is an updated version of #2336 and #7694. --- This adds a `registrationError` event that is emitted by `PushNotificationIOS` whenever an application receives a registration error from APNS (APNS service failure, running on simulator, etc). This event fires to the exclusion of the `register` event (and vice versa). **How to use** Add the following to your `AppDelegate.m`: ```obj-c - (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error { [RCTPushNotificationManager didFailToRegisterForRemoteNotificationsWithError:error]; } ``` And register an event handler for the event: ```js PushNotificationIOS.addEventListener('registrationError', function({ message, code }) { // Complete your registration process in error. }); ``` **Test plan** Added support for this event (and `register`) to UIExplorer as a proof of concept. Navigating to the push notifications example on a simulator is an easy way to reproduce this e Closes facebook/react-native#9650 Differential Revision: D3822142 Pulled By: javache fbshipit-source-id: a15ed8941b74dc3eed2c44c658deccbcaf39ce3d
mikelambert
pushed a commit
to mikelambert/react-native
that referenced
this pull request
Sep 29, 2016
Summary: This is an updated version of facebook#2336 and facebook#7694. --- This adds a `registrationError` event that is emitted by `PushNotificationIOS` whenever an application receives a registration error from APNS (APNS service failure, running on simulator, etc). This event fires to the exclusion of the `register` event (and vice versa). **How to use** Add the following to your `AppDelegate.m`: ```obj-c - (void)application:(UIApplication *)application didFailToRegisterForRemoteNotificationsWithError:(NSError *)error { [RCTPushNotificationManager didFailToRegisterForRemoteNotificationsWithError:error]; } ``` And register an event handler for the event: ```js PushNotificationIOS.addEventListener('registrationError', function({ message, code }) { // Complete your registration process in error. }); ``` **Test plan** Added support for this event (and `register`) to UIExplorer as a proof of concept. Navigating to the push notifications example on a simulator is an easy way to reproduce this e Closes facebook#9650 Differential Revision: D3822142 Pulled By: javache fbshipit-source-id: a15ed8941b74dc3eed2c44c658deccbcaf39ce3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #2336 and #7694.
This adds a
registrationErrorevent that is emitted byPushNotificationIOSwhenever an application receives a registration error from APNS (APNS service failure, running on simulator, etc). This event fires to the exclusion of theregisterevent (and vice versa).How to use
Add the following to your
AppDelegate.m:And register an event handler for the event:
Test plan
Added support for this event (and
register) to UIExplorer as a proof of concept. Navigating to the push notifications example on a simulator is an easy way to reproduce this event.