[XMLHttpRequest] Uppercases the method variable to sanitize the string
#6956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents possible developer errors when using 'post' or 'put' instead of 'POST' and 'PUT'. Fixes: facebook#6855
|
By analyzing the blame information on this pull request, we identified @nicklockwood, @davidaurelio and @lexs to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:This prevents possible developer errors when using 'post' or 'put' instead of 'POST' and 'PUT'. Fixes: facebook#6855 **Test plan:** Previously, a `method put must not have a request body` error would be thrown when the method was in lowercase and a request body was indeed included. With this fix and the following code (note the method name in all lowercase), the request is properly completed. ```javascript const url = 'http://myurl.com'; const request = new XMLHttpRequest(); request.open('put', url); request.setRequestHeader("Content-type","application/json"); request.onload = function() { console.log('onload'); }; request.onerror = function() { console.log('error'); }; request.send(JSON.stringify({ something: 'here' })); ``` Closes facebook#6956 Differential Revision: D3173467 Pulled By: davidaurelio fb-gh-sync-id: add90e9f31cd4f548547a3f85267a782ae74a89c fbshipit-source-id: add90e9f31cd4f548547a3f85267a782ae74a89c
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents possible developer errors when using 'post' or 'put' instead of 'POST' and 'PUT'.
Fixes: #6855
Test plan:
Previously, a
method put must not have a request bodyerror would be thrown when the method was in lowercase and a request body was indeed included.With this fix and the following code (note the method name in all lowercase), the request is properly completed.