Ability to supply product flavor for react-native run-android command
#6010
Conversation
|
By analyzing the blame information on this pull request, we identified @martinbigio, @mkonicek and @foghina to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
@alwx updated the pull request. |
| args['option-flavor'][0].toUpperCase() + args['option-flavor'].slice(1) | ||
| ); | ||
| } else { | ||
| gradleArgs.push("installDebug"); |
There was a problem hiding this comment.
nit: Use single quotes for consistency with the rest of the file.
|
Looks good in general, thanks! Should the arg be added to the |
|
@alwx updated the pull request. |
1 similar comment
|
@alwx updated the pull request. |
|
@mkonicek I've updated my PR. Please, check it again. |
|
One last small thing I realized: is there are a reason to call it How about Sorry for the back and forth on this. |
|
@alwx updated the pull request. |
1 similar comment
|
@alwx updated the pull request. |
|
@alwx updated the pull request. |
|
@mkonicek I've updated it. Please, check it again. |
|
Thanks for the ping @alwx! @facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
Summary:This small update to runAndroid.js allows to specify product flavor as optional argument, like that: `react-native run-android --option-flavor=staging` This option is useful when developing complex applications that require some flavor-specific functionality. More information about productFlavors can be found here: http://developer.android.com/intl/ru/tools/building/configuring-gradle.html Closes facebook#6010 Differential Revision: D3011662 Pulled By: mkonicek fb-gh-sync-id: ce730a17340c1f21b5d75f28a784db4d6fd99725 shipit-source-id: ce730a17340c1f21b5d75f28a784db4d6fd99725
Summary:This small update to runAndroid.js allows to specify product flavor as optional argument, like that: `react-native run-android --option-flavor=staging` This option is useful when developing complex applications that require some flavor-specific functionality. More information about productFlavors can be found here: http://developer.android.com/intl/ru/tools/building/configuring-gradle.html Closes facebook/react-native#6010 Differential Revision: D3011662 Pulled By: mkonicek fb-gh-sync-id: ce730a17340c1f21b5d75f28a784db4d6fd99725 shipit-source-id: ce730a17340c1f21b5d75f28a784db4d6fd99725
This small update to runAndroid.js allows to specify product flavor as optional argument, like that:
react-native run-android --option-flavor=stagingThis option is useful when developing complex applications that require some flavor-specific functionality. More information about productFlavors can be found here: http://developer.android.com/intl/ru/tools/building/configuring-gradle.html