Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove String.prototype.contains polyfill #5794

Closed
wants to merge 1 commit into from
Closed

Remove String.prototype.contains polyfill #5794

wants to merge 1 commit into from

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Feb 7, 2016

Now that String.prototype.includes is there, we should remove the .contains one which has not been standardized.

For fb reviewers, this needs to land after D2910339 which updates internal callsites.

@vjeux
Remove String.prototype.contains polyfill
12868bb 
Now that String.prototype.includes is there, we should remove the .contains one which has not been standardized.

For fb reviewers, this needs to land after D2910339 which updates internal callsites.
@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @yungsters and @cosmith to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 7, 2016
@cosmith
Copy link
Contributor

cosmith commented Feb 7, 2016

Just want to point out that this is potentially breaking for some people so
we should remember to include it in the release notes for the next version !

Le dim. 7 févr. 2016 07:31, Facebook Community Bot notifications@github.com
a écrit :

By analyzing the blame information on this pull request, we identified
@yungsters https://github.com/yungsters and @cosmith
https://github.com/cosmith to be potential reviewers.

—
Reply to this email directly or view it on GitHub
#5794 (comment)
.

@vjeux
Copy link
Contributor Author

vjeux commented Feb 7, 2016

👍

@vjeux
Copy link
Contributor Author

vjeux commented Feb 7, 2016

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1126038830753231/int_phab to review.

@ghost ghost closed this in 577206f Feb 8, 2016
@bestander bestander deleted the vjeux-patch-7 branch March 1, 2016 17:58
pglotov pushed a commit to pglotov/react-native that referenced this pull request Mar 15, 2016
@vjeux @pglotov
Remove String.prototype.contains polyfill
32465fc 
Summary:
Now that String.prototype.includes is there, we should remove the .contains one which has not been standardized.

For fb reviewers, this needs to land after D2910339 which updates internal callsites.
Closes facebook#5794

Reviewed By: svcscm

Differential Revision: D2910855

Pulled By: vjeux

fb-gh-sync-id: 8fd216222385f038995d1ed10e8a2c4c34c7e928
cpojer pushed a commit to facebook/metro that referenced this pull request Jan 26, 2017
@vjeux
Remove String.prototype.contains polyfill
f6af247 
Summary:
Now that String.prototype.includes is there, we should remove the .contains one which has not been standardized.

For fb reviewers, this needs to land after D2910339 which updates internal callsites.
Closes facebook/react-native#5794

Reviewed By: svcscm

Differential Revision: D2910855

Pulled By: vjeux

fb-gh-sync-id: 8fd216222385f038995d1ed10e8a2c4c34c7e928
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vjeux @facebook-github-bot @cosmith