[Inspector]Fix inspector for displaying styles' value #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleInspector will occur a error if a style's value is an object, such as transform. Now it converts the value to string before display.
|
By analyzing the blame information on this pull request, we identified @none to be a potential reviewer. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/840009142788328/int_phab to review. |
ghost
closed this
in
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary: StyleInspector will occur a error if a style's value is an object, such as transform. Now it converts the value to string before display. fix issue facebook#5774 . Now it can display okay.  Closes facebook#5777 Reviewed By: svcscm Differential Revision: D2908135 Pulled By: nicklockwood fb-gh-sync-id: 5914f9e9538f90ae9a38ef7d8dc85b2df84ec43e
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StyleInspector will occur a error if a style's value is an object, such as transform. Now it converts the value to string before display.
fix issue #5774 .
Now it can display okay.