Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpful description for native-js prop mismatch #5673

Closed
wants to merge 2 commits into from

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Feb 1, 2016

Similar as #5605

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @tadeuzagallo, @nicklockwood and @mhorowitz to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 1, 2016
@facebook-github-bot
Copy link
Contributor

@vjeux updated the pull request.

@nicklockwood
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/591409447674518/int_phab to review.

@ghost ghost closed this in 375abc3 Feb 6, 2016
@bestander bestander deleted the vjeux-patch-4 branch March 1, 2016 17:58
pglotov pushed a commit to pglotov/react-native that referenced this pull request Mar 15, 2016
Summary:
Similar as facebook#5605
Closes facebook#5673

Reviewed By: svcscm

Differential Revision: D2908218

Pulled By: nicklockwood

fb-gh-sync-id: da5e42ea660df2c0bb60165c7429d480414a0a20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants