[AsyncStorage] multiGet breaking test and fix #5514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @sahrens, @vjeux and @nicklockwood to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@mvayngrib updated the pull request. |
mvayngrib
changed the title
| // avoid fetching duplicates | ||
| keys.forEach(key => { | ||
| if (this._getKeys.indexOf(key) === -1) { | ||
| this._getKeys.push(key) |
mvayngrib
force-pushed
the
asyncStorageTest
branch
from
aac0236 to
dde151a
Compare
|
@mvayngrib updated the pull request. |
| @@ -225,7 +228,12 @@ var AsyncStorage = { | |||
| }); | |||
|
|
|||
| this._getRequests.push(getRequest); | |||
| this._getKeys.push.apply(this._getKeys, keys); | |||
| // avoid fetching duplicates | |||
| keys.forEach(key => { | |||
mvayngrib
force-pushed
the
asyncStorageTest
branch
from
dde151a to
be5c91b
Compare
|
@mvayngrib updated the pull request. |
|
cc @vjeux |
|
To anyone else that experiences this bug and is on an older version with unpatched AsyncStorage - you could just swap out your |
|
@mvayngrib thanks so much btw |
|
@niftylettuce you're welcome :) |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1753159551581590/int_phab to review. |
ghost
closed this
in
bestander
pushed a commit
that referenced
this pull request
Feb 15, 2016
Summary: the flush + optimized multiGet result in an obscure bug that results when two multiGet requests with overlapping key sets get issued. The result array for both requests ends up bigger than the key array (because it has duplicates) Closes #5514 Reviewed By: svcscm Differential Revision: D2908264 Pulled By: nicklockwood fb-gh-sync-id: 60be1bce4acfc47083e4ae28bb8b63f9dfa56039
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary: the flush + optimized multiGet result in an obscure bug that results when two multiGet requests with overlapping key sets get issued. The result array for both requests ends up bigger than the key array (because it has duplicates) Closes facebook#5514 Reviewed By: svcscm Differential Revision: D2908264 Pulled By: nicklockwood fb-gh-sync-id: 60be1bce4acfc47083e4ae28bb8b63f9dfa56039
Corey-Peyton
added a commit
to Corey-Peyton/async-storage
that referenced
this pull request
Jul 14, 2021
Summary: the flush + optimized multiGet result in an obscure bug that results when two multiGet requests with overlapping key sets get issued. The result array for both requests ends up bigger than the key array (because it has duplicates) Closes facebook/react-native#5514 Reviewed By: svcscm Differential Revision: D2908264 Pulled By: nicklockwood fb-gh-sync-id: 60be1bce4acfc47083e4ae28bb8b63f9dfa56039
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the flush + optimized multiGet result in an obscure bug that results when two multiGet requests with overlapping key sets get issued. The result array for both requests ends up bigger than the key array (because it has duplicates)