feat: add disabledButtonTintColor prop in ActionSheetIOS

[henninghall]

Summary:

Problem

Setting the tintColor prop in ActionSheetIOS also changes the tint of disabled entries. This could make them visually indistinguishable from enabled items. The degree to which they are indistinguishable depends on the tint color.

Solution

This new prop disabledButtonTintColor allows customization of disabled items' tint color.

Related PR: #31972

Changelog:

[IOS] [ADDED] - added disabledButtonTintColor prop to ActionSheetIOS

Test Plan:

Tested in RNTester project.

Before	After
Before	After

[facebook-github-bot]

Hi @henninghall!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[henninghall]

@cortinico I there anything I can do to get someone to take a look at this PR? 🙏

[cipolleschi]

This looks good, thanks for the contribution

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[lunaleaps]

Commented on the imported PR but wondering about this

Setting the tintColor prop in ActionSheetIOS also changes the tint of disabled entries

Could we change ActionSheetIOS to not set the same tintColor to disabled entries? Or is that out of our control?

[lunaleaps]

In addition, if a user didn't set disabledButtonTintColor, but did set tintColor, with this PR, would we still set the disabled action button tint color to tintColor? Should we also do the same thing for the cancel form?

[cipolleschi]

Could we change ActionSheetIOS to not set the same tintColor to disabled entries? Or is that out of our control?

@lunaleaps this will break other apps that depend on the color being set.

[lunaleaps]

Could we change ActionSheetIOS to not set the same tintColor to disabled entries? Or is that out of our control?

@lunaleaps this will break other apps that depend on the color being set.

Would it be worth a breaking change? Or is this component something we don't want to actively support? Overall I'd say my comments aren't blocking but since we're looking at this anyway

[cipolleschi]

Would it be worth a breaking change?

This would be a subtle breaking change, because it's just a behavioral one. So it easier for it to go unnoticed. I'd rather to avoid breaking the component to avoid the confusion.

Or is this component something we don't want to actively support?

So far, we are supporting it. However, it is an amazing candidate to go into Lean Core 2.0.

[facebook-github-bot]

@cipolleschi merged this pull request in 089c87e.

[react-native-bot]

This pull request was successfully merged by @henninghall in 089c87e

^{When will my fix make it into a release? | How to file a pick request?}