[iOS] automaticallyAdjustKeyboardInsets not shifting scrollview content #46732
Conversation
facebook-github-bot
added
CLA Signed
| #import "UIResponder+React.h" | ||
|
|
||
| static __weak id reactCurrentFirstResponder; | ||
|
|
||
| @implementation UIResponder (React) | ||
| + (id)reactCurrentFirstResponder | ||
| { | ||
| reactCurrentFirstResponder = nil; | ||
| [[UIApplication sharedApplication] sendAction:@selector(reactFindFirstResponder:) to:nil from:nil forEvent:nil]; | ||
| return reactCurrentFirstResponder; | ||
| } | ||
|
|
||
| - (void)reactFindFirstResponder:(id)sender | ||
| { | ||
| reactCurrentFirstResponder = self; | ||
| } |
There was a problem hiding this comment.
This is something we used to have and we removed it. It is seen as an anti-pattern, so we'd rather not have it. Probably @javache has more context on why it got removed.
There was a problem hiding this comment.
@cipolleschi I changed another way to find first responder :)
There was a problem hiding this comment.
I found why: the previous API is a private API #37766 (comment)
There was a problem hiding this comment.
I don't think is private API because we're using our own selector reactFindFirstResponder. Let's see if we can avoid adding another action though.
| @@ -34,6 +34,7 @@ @implementation RCTBaseTextInputView { | |||
|
|
|||
| - (void)reactUpdateResponderOffsetForScrollView:(RCTScrollView *)scrollView | |||
| { | |||
| scrollView.firstResponderFocusView = self.backedTextInputView; | |||
There was a problem hiding this comment.
This should respect the early return.
There was a problem hiding this comment.
@javache I optimized the code to only store it when the first responder is outside the scroll view.
| /** Focus area of newly-activated text input relative to the window to compare against UIKeyboardFrameBegin/End */ | ||
| @property (nonatomic, assign) CGRect firstResponderFocus; | ||
| /** newly-activated text input relative to the window to compare against UIKeyboardFrameBegin/End */ | ||
| @property (nonatomic, weak) UIView *firstResponderFocusView; |
There was a problem hiding this comment.
There's a lot of overlap between these two fields. If we're going to be storing the focusView anyway, can we get rid of the focus rect and instead add a reactFocusFrame to UIView+React?
| @@ -102,6 +102,7 @@ - (void)didMoveToWindow | |||
|
|
|||
| - (void)reactUpdateResponderOffsetForScrollView:(RCTScrollViewComponentView *)scrollView | |||
| { | |||
| scrollView.firstResponderFocusView = _backedTextInputView; | |||
Summary:
Fixes #46595 . It seems #37766 broke the
automaticallyAdjustKeyboardInsetswhen input accessory view become first responder.Changelog:
[IOS] [FIXED] - automaticallyAdjustKeyboardInsets not shifting scrollview content
Test Plan:
Repro please see in ##46595 .