Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.75] RGNP - Remove unnecessary dependency on gradle-tooling-api-builders - serviceOf failure #46367

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

cortinico
Copy link
Contributor

Summary:

This removes an unnucessary dependency on gradle-tooling-api-builders which is causing a failure on 0.75.

The fix is already landed in main.

Fixes #32858

Changelog:

[ANDROID] [FIXED] - Fixed build error in Gradle due to missing serviceOf import

Test Plan:

CI

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,743,782 -611,074
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,945,523 -604,468
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@david-cahill
Copy link

@cortinico Thanks for this! Any idea when it might be released?

@cipolleschi cipolleschi merged commit 1067798 into 0.75-stable Sep 11, 2024
91 checks passed
@cipolleschi cipolleschi deleted the nc/remove-serviceOf branch September 11, 2024 09:15
@cortinico
Copy link
Contributor Author

@cortinico Thanks for this! Any idea when it might be released?

We will include it inside 0.75.3 which will be out in the coming days/weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants