Implement outline properties on Android
#46284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61293868 |
|
This pull request was exported from Phabricator. Differential Revision: D61293868 |
jorge-cab
force-pushed
the
export-D61293868
branch
from
4b35dd5
to
069c537
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebook#46284 This diff adds: `outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width `outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color `outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style `outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset Using `BackgroundStyleApplicator` Changelog: [Android] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset` Differential Revision: D61293868
|
This pull request was exported from Phabricator. Differential Revision: D61293868 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 4, 2024
Summary: Pull Request resolved: facebook#46284 This diff adds: `outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width `outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color `outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style `outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset Using `BackgroundStyleApplicator` Changelog: [Android] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset` Differential Revision: D61293868
jorge-cab
force-pushed
the
export-D61293868
branch
from
069c537
to
25c31e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61293868 |
jorge-cab
force-pushed
the
export-D61293868
branch
from
25c31e7
to
b9049f1
Compare
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 12, 2024
Summary: Pull Request resolved: facebook#46284 This diff adds: `outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width `outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color `outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style `outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset Using `BackgroundStyleApplicator` Changelog: [Android] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset` Differential Revision: D61293868
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 12, 2024
…6284) Summary: Pull Request resolved: facebook#46284 This diff adds: `outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width `outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color `outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style `outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset Using `BackgroundStyleApplicator` Changelog: [Android] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset` Differential Revision: D61293868
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Sep 13, 2024
…6284) Summary: Pull Request resolved: facebook#46284 This diff adds: `outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width `outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color `outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style `outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset Using `BackgroundStyleApplicator` Changelog: [Android] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset` Differential Revision: D61293868
Summary: Pull Request resolved: facebook#46284 This diff adds: `outline-width`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-width `outline-color`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-color `outline-style`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-style `outline-offset`: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offset Using `BackgroundStyleApplicator` Changelog: [Android] [Added] - Outline properties `outline-width`, `outline-color`, `outline-style` & `outline-offset` Reviewed By: NickGerleman Differential Revision: D61293868
|
This pull request was exported from Phabricator. Differential Revision: D61293868 |
jorge-cab
force-pushed
the
export-D61293868
branch
from
b9049f1
to
a6c1b79
Compare
|
This pull request has been merged in 17faac4. |
|
This pull request was successfully merged by @jorge-cab in 17faac4 When will my fix make it into a release? | How to file a pick request? |
github-merge-queue bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Oct 3, 2024
## Summary Add support for animating the `outlineColor` prop, introduced in `react-native` via facebook/react-native#46284, by including it in the ColorProperties list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds:
outline-width: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-widthoutline-color: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-coloroutline-style: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-styleoutline-offset: https://developer.mozilla.org/en-US/docs/Web/CSS/outline-offsetUsing
BackgroundStyleApplicatorChangelog: [Android] [Added] - Outline properties
outline-width,outline-color,outline-style&outline-offsetDifferential Revision: D61293868