-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict durationThreshold to event entry types only #45524
Conversation
This pull request was exported from Phabricator. Differential Revision: D59918519 |
This pull request was exported from Phabricator. Differential Revision: D59918519 |
Summary: Pull Request resolved: facebook#45524 Changelog: [internal] The `durationThreshold` option is only meant to be used with `event` entry types. `mark`, `measure`, `longtask`, etc. shouldn't take that option into account, as per the spec. Differential Revision: D59918519
de610bd
to
7fab06c
Compare
This pull request was exported from Phabricator. Differential Revision: D59918519 |
Summary: Pull Request resolved: facebook#45524 Changelog: [internal] The `durationThreshold` option is only meant to be used with `event` entry types. `mark`, `measure`, `longtask`, etc. shouldn't take that option into account, as per the spec. Reviewed By: mdvacca Differential Revision: D59918519
7fab06c
to
fcaa798
Compare
Summary: Pull Request resolved: facebook#45524 Changelog: [internal] The `durationThreshold` option is only meant to be used with `event` entry types. `mark`, `measure`, `longtask`, etc. shouldn't take that option into account, as per the spec. Reviewed By: mdvacca Differential Revision: D59918519
This pull request was exported from Phabricator. Differential Revision: D59918519 |
fcaa798
to
10f3b7b
Compare
This pull request has been merged in 9b06ac8. |
This pull request was successfully merged by @rubennorte in 9b06ac8 When will my fix make it into a release? | How to file a pick request? |
Summary:
Changelog: [internal]
The
durationThreshold
option is only meant to be used withevent
entry types.mark
,measure
,longtask
, etc. shouldn't take that option into account, as per the spec.Differential Revision: D59918519