provide default implementation for ReactHostDelegate.handleInstanceException() #45521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59847543 |
…ception() (facebook#45521) Summary: Pull Request resolved: facebook#45521 [ReactHostDelegate.handleInstanceException()](https://github.com/facebook/react-native/blob/a6f5e5adebed3d9da411f99548e2d8ce96636e16/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactHostDelegate.kt#L48) is a no-op so providing a default implementation for this. As a simplified solution, just throw a `RuntimeException` (on non-debug bulid) in this case. Below is the justification. 1) We may want to consider using `ExceptionsManagerModule` TurboModule in OSS to report the exception but current implementation just [throws JavaScriptException](https://github.com/facebook/react-native/blob/a6f5e5adebed3d9da411f99548e2d8ce96636e16/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/core/ExceptionsManagerModule.java#L67) when it is fatal 2) If the exception happens during ReactInstance initialization then we may not have Turbo Module initialized and may not be able to access it. While we might want to fix how this works in longer term but for now just throw an Exception and let the app handle it. 3) In debug build, `DevSupportManager` is called before `handleInstanceException()` which would display a RedBox so don't throw when it is a debug build. So it seems to best for now to just throw an exception so it can be handled by the app than silently ignoring it. Changelog: [Android][Added] - provide default implementation for ReactHostDelegate.handleInstanceException() Reviewed By: javache Differential Revision: D59847543
|
This pull request was exported from Phabricator. Differential Revision: D59847543 |
alanleedev
force-pushed
the
export-D59847543
branch
from
55c151a
to
8376299
Compare
|
This pull request has been merged in 34e3a6c. |
|
This pull request was successfully merged by @alanleedev in 34e3a6c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ReactHostDelegate.handleInstanceException() is a no-op so providing a default implementation for this.
As a simplified solution, just throw a
RuntimeException(on non-debug bulid) in this case. Below is the justification.We may want to consider using
ExceptionsManagerModuleTurboModule in OSS to report the exception but current implementation just throws JavaScriptException when it is fatalIf the exception happens during ReactInstance initialization then we may not have Turbo Module initialized and may not be able to access it. While we might want to fix how this works in longer term but for now just throw an Exception and let the app handle it.
In debug build,
DevSupportManageris called beforehandleInstanceException()which would display a RedBox so don't throw when it is a debug build.So it seems to best for now to just throw an exception so it can be handled by the app than silently ignoring it.
Changelog:
[General][Android] - provide default implementation for ReactHostDelegate.handleInstanceException()
Differential Revision: D59847543