Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DOM APIs to native module #43512

Closed
wants to merge 1 commit into from

Conversation

rubennorte
Copy link
Contributor

@rubennorte rubennorte commented Mar 15, 2024

Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.

Differential Revision: D54903376

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 18, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 18, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 19, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

@analysis-bot
Copy link

analysis-bot commented Mar 19, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,093,695 -32,241
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,458,700 -32,569
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1fe8267
Branch: main

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

rubennorte added a commit to rubennorte/react-native that referenced this pull request Mar 20, 2024
Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

Summary:
Changelog: [internal]

This moves all the new methods that were added to implement the DOM traversal and layout APIs (as per this RFC: react-native-community/discussions-and-proposals#607) to a separate C++ native module to avoid bloating the UIManager interface, initialize lazily, provide automatic caching of methods, simplify the API for implementors, etc.


Reviewed By: sammy-SC

Differential Revision: D54903376
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54903376

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0267ca0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants