[0.73-stable] Cherry-pick improvements to monorepo publish script #42991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…42936) Summary: Pull Request resolved: facebook#42936 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607809 fbshipit-source-id: 990826fda5538af9a13e3f24978295a2f3b0c8c3 # Conflicts: # scripts/monorepo/__tests__/find-and-publish-all-bumped-packages-test.js # scripts/monorepo/find-and-publish-all-bumped-packages.js
Summary: Pull Request resolved: facebook#42937 Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607810 fbshipit-source-id: 18e79f23060ee70e96bd8ac6e9995b0a8ba300b3 # Conflicts: # scripts/monorepo/__tests__/find-and-publish-all-bumped-packages-test.js # scripts/monorepo/find-and-publish-all-bumped-packages.js
Summary: Pull Request resolved: facebook#42938 Substitutes the `forEachPackage` util with a replacement async `getPackages` function. This will be used further in the next diff. The new function aims to be more erganomic/versatile than `forEachPackage` by returning a package mapping (see updated test mock). The API aligns roughly with `yarn workspaces list` and [Lerna's `detectProjects`](https://lerna.js.org/docs/api-reference/utilities#detectprojects). This also aligns with / replaces similar attempts in our existing scripts: - [`getPackagesToPublish`](https://github.com/facebook/react-native/blob/2ca7bec0c2a7d821ceaaf39840a6cdc5eceb8678/scripts/monorepo/get-and-update-packages.js#L56) - [`getPublicPackages`](https://github.com/facebook/react-native/blob/2ca7bec0c2a7d821ceaaf39840a6cdc5eceb8678/scripts/releases/set-version/index.js#L19) Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607806 fbshipit-source-id: 00ec34edadab863dc8f2f0c7852f6e835a5dddf5 # Conflicts: # scripts/monorepo.js # scripts/monorepo/find-and-publish-all-bumped-packages.js # scripts/monorepo/for-each-package.js
…rerunnable) (facebook#42944) Summary: Pull Request resolved: facebook#42944 Updates `find-and-publish-all-bumped-packages` to use the npm registry as the source of truth, similar to tools like Lerna (`lerna publish from-package`). **This enables safe reruns of the publish script**, and replaces the previous Git-diff-detection implementation. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D53607807 fbshipit-source-id: 135808b7ce36cf463c9f53a8059500b83f8b6679 # Conflicts: # scripts/monorepo/find-and-publish-all-bumped-packages.js
Summary: Pull Request resolved: facebook#42964 We've seen npm publishes fail occasionally in CI as part of this script, most recently in S391653. This change adds a single retry, per package, during the execution of this script, in an attempt to reduce the chance of manual interventions after a broken pipeline. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607808 fbshipit-source-id: 526d9c33d51ec57702efba3c199bad313c1bf2d4 # Conflicts: # scripts/monorepo/find-and-publish-all-bumped-packages.js
Summary: Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53607805 fbshipit-source-id: babe9bbd7fb5e7016b567193727c6a441bee60a3 # Conflicts: # scripts/__tests__/publish-updated-packages-test.js # scripts/publish-updated-packages.js # scripts/releases-ci/README.md
facebook-github-bot
added
CLA Signed
huntie
commented
Feb 13, 2024
| } | ||
|
|
||
| module.exports = { | ||
| getPackages, |
There was a problem hiding this comment.
@lunaleaps Note that I have not included getTagsFromCommitMessage in this PR.
There was a problem hiding this comment.
@huntie What was the reasoning for not including it? It looks like we use it still here: https://github.com/facebook/react-native/pull/42991/files/15501fe0d284335ff23b9ef38439ec475b639819#diff-cae21f4d9bde2c43bb8e1cb52cd9318106ae3b41483880f260b1a766cafab203R98
|
Base commit: 4d07aae |
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks the following updates to our
find_and_publish_bumped_packagesCI workflow onto the0.73-stablebranch (Meta employees: stack beginning D53607809):These changes should make
find_and_publish_bumped_packages1/ more reliable (built-in network retry), 2/ re-runnable (uses npm as source of truth, meaning it can be rerun from an incomplete previous attempt).The script is renamed from
scripts/monorepo/find-and-publish-all-bumped-packages.jstoscripts/releases-ci/publish-updated-packages.