-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'[skip ci] [RN][Android] Mark classes of package animated as @Nullsafe #42727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Jan 30, 2024
This pull request was exported from Phabricator. Differential Revision: D53200096 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 30, 2024
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D53200096
mdvacca
force-pushed
the
export-D53200096
branch
from
January 30, 2024 08:09
0b5e9ba
to
fcf86fd
Compare
This pull request was exported from Phabricator. Differential Revision: D53200096 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 30, 2024
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D53200096
mdvacca
force-pushed
the
export-D53200096
branch
from
January 30, 2024 19:10
fcf86fd
to
6914342
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Jan 30, 2024
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D53200096
This pull request was exported from Phabricator. Differential Revision: D53200096 |
Base commit: 2f818b4 |
Summary: initHybrid always return a HybridData. we shouldn't allow null here. changelog: [internal] internal Reviewed By: cortinico, NickGerleman Differential Revision: D53200101
Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D53200096
mdvacca
force-pushed
the
export-D53200096
branch
from
January 31, 2024 00:03
6914342
to
f919e9a
Compare
This pull request was exported from Phabricator. Differential Revision: D53200096 |
This pull request has been merged in 25c5d1c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All these classes are NullSafe, let'''s mark them as NullSafe(Local) to ensure lint detect errors in the future
changelog: [internal] internal
Reviewed By: NickGerleman
Differential Revision: D53200096