Fix flooring of border #42411
Closed
Fix flooring of border #42411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
NickGerleman
force-pushed
the
export-D52930827
branch
from
c24c924
to
933e334
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
Base commit: cfcf3a3 |
NickGerleman
force-pushed
the
export-D52930827
branch
from
933e334
to
ebcaf14
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 22, 2024
Summary: X-link: facebook/react-native#42411 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 22, 2024
Summary: X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 22, 2024
Summary: X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
force-pushed
the
export-D52930827
branch
from
ebcaf14
to
5c24c6d
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 22, 2024
Summary: X-link: facebook/react-native#42411 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
force-pushed
the
export-D52930827
branch
from
5c24c6d
to
cb5fc5e
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/react-native#42411 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/react-native#42411 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
force-pushed
the
export-D52930827
branch
from
cb5fc5e
to
095bed3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
force-pushed
the
export-D52930827
branch
from
095bed3
to
8c011ce
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/react-native#42411 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/react-native#42411 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
force-pushed
the
export-D52930827
branch
from
8c011ce
to
5558416
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
Summary: X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/react-native#42411 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827
NickGerleman
force-pushed
the
export-D52930827
branch
from
5558416
to
bd842df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52930827 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/react-native#42411 X-link: facebook/yoga#1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827 fbshipit-source-id: e165dade705a8de54c92d65f3664c9081137788c
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Jan 23, 2024
Summary: X-link: facebook/react-native#42411 Pull Request resolved: #1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827 fbshipit-source-id: e165dade705a8de54c92d65f3664c9081137788c
|
This pull request has been merged in e27452a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node.
Differential Revision: D52930827