Introduce "outputDir" property of "codegenConfig" #41782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
Base commit: 5d1eac0 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 4, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
force-pushed
the
export-D51494009
branch
from
4fe8a62
to
9026e9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 4, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
force-pushed
the
export-D51494009
branch
from
9026e9b
to
cba3c90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 11, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
force-pushed
the
export-D51494009
branch
from
cba3c90
to
c80b9d0
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 11, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
dmytrorykun
force-pushed
the
export-D51494009
branch
from
c80b9d0
to
4c32c0c
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 12, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 13, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
force-pushed
the
export-D51494009
branch
from
4c32c0c
to
4c9d79d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 13, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 14, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
force-pushed
the
export-D51494009
branch
from
4c9d79d
to
b19967d
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 14, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 14, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 14, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
force-pushed
the
export-D51494009
branch
from
b19967d
to
1660bcb
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 15, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 15, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Dec 15, 2023
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
Summary: This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009
dmytrorykun
force-pushed
the
export-D51494009
branch
from
1660bcb
to
8ff060e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51494009 |
|
This pull request was successfully merged by @dmytrorykun in d45a01d. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41782 This diff adds `outputDir` property to `codegenConfig`. Now codegen output dir is resolved like this: 1. It is set to `outputDir` argument of `generate-codegen-artifacts.js` if it is present. 2. *[New]* It is set to `outputDir` property of `codegenConfig` if it is present. 3. It is set to the project root. Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig" Reviewed By: cipolleschi Differential Revision: D51494009 fbshipit-source-id: 0f6e3607b29a3c6d228a88a9460d55bb65c7e55a
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds
outputDirproperty tocodegenConfig.Now codegen output dir is resolved like this:
outputDirargument ofgenerate-codegen-artifacts.jsif it is present.outputDirproperty ofcodegenConfigif it is present.Changelog: [General][Added] - Introduce "outputDir" property of "codegenConfig"
Reviewed By: cipolleschi
Differential Revision: D51494009