Use C++17 namespace #41771
Closed
Use C++17 namespace #41771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
Base commit: 974e584 |
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
8378140 to
8fb8b75
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
8fb8b75 to
77f5a1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
77f5a1a to
cd2ef87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
cd2ef87 to
915b963
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
915b963 to
44b1620
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
44b1620 to
b5359f5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
b5359f5 to
a790e1d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
a790e1d to
8d9c3f9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991
christophpurrer
force-pushed
the
export-D51789991
branch
from
d1a7029 to
d79c52d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Pull Request resolved: facebook#41771 Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991 fbshipit-source-id: 44adf1b3c8e5cdb452d2860599f1c9da4bcb652e
christophpurrer
force-pushed
the
export-D51789991
branch
from
d79c52d to
90b6ba3
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Pull Request resolved: facebook#41771 Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Differential Revision: https://internalfb.com/D51789991 fbshipit-source-id: 193dee531741df59d3346383a294d8a5b42e1bf8
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Pull Request resolved: facebook#41791 Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740 fbshipit-source-id: 0807ab222db76ef95ea1a1f63081cbc32132ab4c
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 4, 2023
Summary: Pull Request resolved: facebook#41771 Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991 fbshipit-source-id: 5c835c39219413f71267680dab20e411ad6dc26e
christophpurrer
force-pushed
the
export-D51789991
branch
from
90b6ba3 to
236efa3
Compare
Summary: Pull Request resolved: facebook#41771 Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991 fbshipit-source-id: 90781b1224ab0bfad87fe40d0dea45f90fe6f9a8
|
This pull request was exported from Phabricator. Differential Revision: D51789991 |
christophpurrer
force-pushed
the
export-D51789991
branch
from
236efa3 to
b3d1ada
Compare
|
This pull request has been merged in b101dd0. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Dec 5, 2023
Summary: Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41771 Changelog: [Internal] Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style Reviewed By: NickGerleman Differential Revision: D51789991 fbshipit-source-id: 165d7d4e652d60ab200e2355e084010a02f470a4
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41791 Same as facebook#41771 - but this time for compoments Changelog: [Internal] Reviewed By: cortinico Differential Revision: D51804740 fbshipit-source-id: 87f4db5dabfce4639f16fdcb1b1df0fee338a555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Since we are already enforcing C++20 (and 17), we can set the namespace declaration to the C++17 style
Differential Revision: D51789991