Update ios pod post_install logic for detecting if hermes is enabled #41286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
Nov 1, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gabrieldonadel
force-pushed
the
@gabrieldonadel/update-react-native-post-install-hermes
branch
from
97d98fb
to
ddc1275
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in d6163d7. When will my fix make it into a release? | Upcoming Releases |
gabrieldonadel
deleted the
@gabrieldonadel/update-react-native-post-install-hermes
branch
huntie
pushed a commit
that referenced
this pull request
Jan 2, 2024
…41286) Summary: Follow up of #41284 (comment) We should not rely on checking if the `React-hermes` pod is present to determine if hermes is enabled ## Changelog: [IOS] [CHANGED] - Update ios pod post_install logic for detecting if hermes is enabled Pull Request resolved: #41286 Test Plan: Run `use_react_native!(hermes => false)` should not add `USE_HERMES = true;` to `project.pbxproj` Reviewed By: blakef Differential Revision: D50899654 Pulled By: cipolleschi fbshipit-source-id: a5ab5b0117c61014e77b780c50bf349da92c6342
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…acebook#41286) Summary: Follow up of facebook#41284 (comment) We should not rely on checking if the `React-hermes` pod is present to determine if hermes is enabled ## Changelog: [IOS] [CHANGED] - Update ios pod post_install logic for detecting if hermes is enabled Pull Request resolved: facebook#41286 Test Plan: Run `use_react_native!(hermes => false)` should not add `USE_HERMES = true;` to `project.pbxproj` Reviewed By: blakef Differential Revision: D50899654 Pulled By: cipolleschi fbshipit-source-id: a5ab5b0117c61014e77b780c50bf349da92c6342
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up of #41284 (comment)
We should not rely on checking if the
React-hermespod is present to determine if hermes is enabledChangelog:
[IOS] [CHANGED] - Update ios pod post_install logic for detecting if hermes is enabled
Test Plan:
Run
use_react_native!(hermes => false)should not addUSE_HERMES = true;toproject.pbxproj