refactor: don't include DevtoolsOverlay & TraceUpdateOverlay in the production bundle

[ecreeth]

Summary:

Currently, when we build the app in production mode the DevtoolsOverlay & TraceUpdateOverlay are bundle

Changelog:

[GENERAL][REMOVED]: removed DevtoolsOverlay & TraceUpdateOverlay from production bundle

Test Plan:

1. Build the app in production mode
2. Check that both DevtoolsOverlay & TraceUpdateOverlay are included in the bundle

[github-actions]

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 1f747a1

[facebook-github-bot]

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[luluwu2032]

All callsites of "mountReactDevToolsOverlays" are already guarded by dev check at

react-native/packages/react-native/Libraries/ReactNative/AppContainer.js

Line 66 in 5cec1ea

if (__DEV__) {

[hoxyq]

All callsites of "mountReactDevToolsOverlays" are already guarded by dev check at

react-native/packages/react-native/Libraries/ReactNative/AppContainer.js

Line 66 in 5cec1ea

if (__DEV__) {

Yes, need to validate that this is enough for Metro to exclude these components from the production bundle. If not, then wrapping in DEV is required.

[ecreeth]

All callsites of "mountReactDevToolsOverlays" are already guarded by dev check at

We need to add the __DEV__ check in mountReactDevToolsOverlays in order to work properly. If we don't do it, metro will remove the code inside of componentDidMount, but won't remove the mountReactDevToolsOverlays related code.

[ecreeth]

You can see that if we don't add the check, the code is included in the bundle. (RN rn0730rc1)

[facebook-github-bot]

@hoxyq merged this pull request in 0004888.