New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Android API < 23 in TextLayoutManager #39679

Closed

mdvacca wants to merge 4 commits into facebook:main from mdvacca:export-D48545502

Contributor

mdvacca commented Sep 26, 2023

Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

f223373

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 90a18e08769e14fc79dd60512bfd61fb489213f7

mdvacca force-pushed the export-D48545502 branch from b51e1aa to f223373 Compare

September 26, 2023 19:41

analysis-bot commented Sep 26, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	16,902,912	-6
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,381,654	+7
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 5be6f49
Branch: main

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

6d5c908

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: d78e3bd082cc11d7aede9330a8942e6e4dd5f522

mdvacca force-pushed the export-D48545502 branch from f223373 to 6d5c908 Compare

September 26, 2023 20:43

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

d95b47d

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 5cb4e9c8ad45990d48d29c6fbfbe881ec8297cc4

mdvacca force-pushed the export-D48545502 branch from 6d5c908 to d95b47d Compare

September 26, 2023 20:50

Contributor

facebook-github-bot commented Sep 26, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

be3f385

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: e14f424c982ed28ffb4c0eb749e5676a9a73e73a

mdvacca force-pushed the export-D48545502 branch from d95b47d to be3f385 Compare

September 26, 2023 20:59

Contributor

facebook-github-bot commented Sep 27, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca force-pushed the export-D48545502 branch from be3f385 to b2f18c8 Compare

September 27, 2023 13:30

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

b2f18c8

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 02b7ca2472ea432a6cad5239127fcb09f135a4ed

Contributor

facebook-github-bot commented Sep 27, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

4eae717

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: cc5d8fc46f2f08af57cd7ccd3abe50161d0b9163

mdvacca force-pushed the export-D48545502 branch from b2f18c8 to 4eae717 Compare

September 27, 2023 14:28

Contributor

facebook-github-bot commented Sep 28, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

599fb89

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 7735cf0fe263aad9f79098c469d7a7901a0078ca

mdvacca force-pushed the export-D48545502 branch from 4eae717 to 599fb89 Compare

September 28, 2023 01:00

github-actions bot commented Sep 28, 2023 •

edited

Loading

	Warnings
⚠️	One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against fe9b8d2

Contributor

facebook-github-bot commented Sep 28, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

826c737

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 75c6ddf9560bca8d09414914147f95dfc1f3f097

mdvacca force-pushed the export-D48545502 branch from 599fb89 to 826c737 Compare

September 28, 2023 19:26

Contributor

facebook-github-bot commented Sep 28, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

5650dce

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 90a433cb6b66d5c2fb0cee7be0637d007494bb01

mdvacca force-pushed the export-D48545502 branch from 826c737 to 5650dce Compare

September 28, 2023 19:33

Contributor

facebook-github-bot commented Sep 28, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

797eea8

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 062df34bc84c9e2844e1192e72d35f4267a77229

mdvacca force-pushed the export-D48545502 branch from 5650dce to 797eea8 Compare

September 28, 2023 19:40

Contributor

facebook-github-bot commented Sep 28, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

6df54bf

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 9d65927ad0d47ae839e78b42abfb6ce660463582

mdvacca force-pushed the export-D48545502 branch from 797eea8 to 6df54bf Compare

September 28, 2023 21:50

Contributor

facebook-github-bot commented Sep 28, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

1c7df76

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: 85c592675c83d555e9df77367f9c07e8bebe518a

mdvacca force-pushed the export-D48545502 branch from 6df54bf to 1c7df76 Compare

September 28, 2023 22:10

Contributor

facebook-github-bot commented Sep 29, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

7823c8c

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: ebba79e4c1a407751a87a462f4a40c7a1449e0c0

mdvacca force-pushed the export-D48545502 branch from 1c7df76 to 7823c8c Compare

September 29, 2023 13:14

Contributor

facebook-github-bot commented Sep 29, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502

mdvacca added a commit to mdvacca/react-native that referenced this pull request


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

5281ac9

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: bc0ca078583444c4057b6862bfeeaf38dbf87bbf

mdvacca force-pushed the export-D48545502 branch from 7823c8c to 5281ac9 Compare

September 29, 2023 13:19

mdvacca added 3 commits

September 29, 2023 07:08


          Remove support for Android API < 23 in ReactTextShadowNode

7ce7f47

Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextShadowNode

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextShadowNode

Differential Revision: D48545511

fbshipit-source-id: dbe6dd654bb64161a227fa17269002f1f22e4a3c


          Remove support for Android API < 23 in ReactTextView

f2632be

Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextView

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextView

Differential Revision: D48545504

fbshipit-source-id: 392bd245bccd7eaeef189df724f1974fb7b380cf


          Remove support for Android API < 23 in TextAttributeProps

033edf5

Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextAttributeProps

chnagelog: [Android][Breaking] Remove support for Android API < 23 in TextAttributeProps

Differential Revision: D48545514

fbshipit-source-id: d38e6ddf2f99679e403dae7f0537d3a0b882ea5a

Contributor

facebook-github-bot commented Sep 29, 2023

This pull request was exported from Phabricator. Differential Revision: D48545502


          Remove support for Android API < 23 in TextLayoutManager (facebook#39679

fe9b8d2

)

Summary:
Pull Request resolved: facebook#39679

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class TextLayoutManager

changelog: [Android][Breaking] Remove support for Android API < 23 in TextLayoutManager

Reviewed By: NickGerleman

Differential Revision: D48545502

fbshipit-source-id: a796aa4501ca4fbf077d79d825308606222b9e6a

mdvacca force-pushed the export-D48545502 branch from 5281ac9 to fe9b8d2 Compare

September 29, 2023 14:11

facebook-github-bot closed this in

4a563f3

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Sep 29, 2023

This pull request has been merged in 4a563f3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner