Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of Android API <23 in ReactActivityDelegate #39663

Closed
wants to merge 2 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 26, 2023

Summary:
Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in

chnagelog: [Android][Breaking] Remove support for Android API < 23 in

Reviewed By: NickGerleman

Differential Revision: D48545501

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545501

@analysis-bot
Copy link

analysis-bot commented Sep 26, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,902,807 +8,566,298
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,381,606 +10,807,158
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: aa1dffb
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545501

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
)

Summary:
Pull Request resolved: facebook#39663

Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in

chnagelog: [Android][Breaking] Remove support for Android API < 23 in

Reviewed By: NickGerleman

Differential Revision: D48545501

fbshipit-source-id: faf5aad8c9755f06e5fb1a4a3d7c02fd36551ebf
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545501

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
)

Summary:
Pull Request resolved: facebook#39663

Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in

chnagelog: [Android][Breaking] Remove support for Android API < 23 in

Reviewed By: NickGerleman

Differential Revision: D48545501

fbshipit-source-id: ebd91d7e5aa727dcf13f7a488b8438a0eb5c9016
Summary:
In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Differential Revision: D48177965

fbshipit-source-id: d09c86b01a1a0bc13ee9bf77821363a911284b6f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545501

)

Summary:
Pull Request resolved: facebook#39663

Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in

chnagelog: [Android][Breaking] Remove support for Android API < 23 in

Reviewed By: NickGerleman

Differential Revision: D48545501

fbshipit-source-id: 35f91f489ee5801d6ed89089434389d1eb05e0f1
@github-actions
Copy link

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against b02b7b5

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3664b8a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants