-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of Android API <23 in ReactActivityDelegate #39663
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Sep 26, 2023
This pull request was exported from Phabricator. Differential Revision: D48545501 |
Base commit: aa1dffb |
This pull request was exported from Phabricator. Differential Revision: D48545501 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
) Summary: Pull Request resolved: facebook#39663 Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in chnagelog: [Android][Breaking] Remove support for Android API < 23 in Reviewed By: NickGerleman Differential Revision: D48545501 fbshipit-source-id: faf5aad8c9755f06e5fb1a4a3d7c02fd36551ebf
mdvacca
force-pushed
the
export-D48545501
branch
from
September 26, 2023 20:41
48347e6
to
b02b7b5
Compare
This pull request was exported from Phabricator. Differential Revision: D48545501 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
) Summary: Pull Request resolved: facebook#39663 Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in chnagelog: [Android][Breaking] Remove support for Android API < 23 in Reviewed By: NickGerleman Differential Revision: D48545501 fbshipit-source-id: ebd91d7e5aa727dcf13f7a488b8438a0eb5c9016
mdvacca
force-pushed
the
export-D48545501
branch
from
September 26, 2023 20:48
b02b7b5
to
7a7ee6e
Compare
Summary: In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk changelog: [Android][Breaking] Increase min sdk version of RN Android to 23 Differential Revision: D48177965 fbshipit-source-id: d09c86b01a1a0bc13ee9bf77821363a911284b6f
This pull request was exported from Phabricator. Differential Revision: D48545501 |
) Summary: Pull Request resolved: facebook#39663 Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in chnagelog: [Android][Breaking] Remove support for Android API < 23 in Reviewed By: NickGerleman Differential Revision: D48545501 fbshipit-source-id: 35f91f489ee5801d6ed89089434389d1eb05e0f1
mdvacca
force-pushed
the
export-D48545501
branch
from
September 26, 2023 20:56
7a7ee6e
to
a13c054
Compare
This pull request has been merged in 3664b8a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in
chnagelog: [Android][Breaking] Remove support for Android API < 23 in
Reviewed By: NickGerleman
Differential Revision: D48545501