Remove usage of Gutters arrays and YGGutter as index #39597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Base commit: f174f02 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 22, 2023
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 3dc06bb17e9c2d4b373d66cfb2ee6c34921a5be5
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 22, 2023
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: e4c4e2702ab9fff345b2227d5f078ddf13c0fdc1
NickGerleman
force-pushed
the
export-D49530923
branch
from
21fb77e
to
69790e6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
NickGerleman
force-pushed
the
export-D49530923
branch
from
69790e6
to
d516aeb
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 9a12dd475febd50e3c52b35c15c040bf038ffe9a
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 651b2937ef1eefc2885dc517a80d819af885f97b
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 3fe0dcdd7f78339b9c4af352df6eed4171fab0d7
NickGerleman
force-pushed
the
export-D49530923
branch
from
d516aeb
to
7c739d8
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 26, 2023
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: cd7064c70cee9715625d17746b805f6269ab825e
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 28, 2023
Summary: X-link: facebook/react-native#39597 Pull Request resolved: facebook#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: a4ebbf52d7f62ad2d50248932b3ba340df3dcfb3
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 28, 2023
Summary: Pull Request resolved: facebook#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Differential Revision: D49530923 fbshipit-source-id: 6d703fd06a37f2ec9df4da4a7209b8ca2babdce6
NickGerleman
force-pushed
the
export-D49530923
branch
from
7c739d8
to
2026aa4
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Oct 3, 2023
Summary: X-link: facebook/react-native#39597 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 3, 2023
Summary: X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
NickGerleman
force-pushed
the
export-D49530923
branch
from
2026aa4
to
af6720d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Oct 3, 2023
Summary: X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
NickGerleman
force-pushed
the
export-D49530923
branch
from
af6720d
to
c76a222
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
Summary: X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Oct 3, 2023
Summary: X-link: facebook/react-native#39597 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923
NickGerleman
force-pushed
the
export-D49530923
branch
from
c76a222
to
6b44f59
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49530923 |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Oct 3, 2023
Summary: X-link: facebook/react-native#39597 Pull Request resolved: #1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923 fbshipit-source-id: 47b06a7301fb283acc493dba159f496159d59580
|
This pull request was successfully merged by @NickGerleman in 4da0d44. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Oct 3, 2023
Summary: X-link: facebook/react-native#39597 X-link: facebook/yoga#1406 Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying. This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later. Reviewed By: rshest Differential Revision: D49530923 fbshipit-source-id: 47b06a7301fb283acc493dba159f496159d59580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Similar in vain to D49362819, we want to stop exposing pre-resolved CompactValue, and allow enum class usage without becoming annoying.
This also simplifies gap resolution a bit. I moved this to Style, to make it clear we aren't relying on any node state. I plan to do some similar cleanup for other resolution later.
Differential Revision: D49530923