switch on return types for invokeObjCMethod instead of cascading if else #39591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
Base commit: 4da0d44 |
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 21, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Differential Revision: D49521866 fbshipit-source-id: 6934ba2d94211d7d67ace0e4eefeb6268fcdee49
philIip
force-pushed
the
export-D49521866
branch
from
e1db14f to
81f662a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 25, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: mdvacca Differential Revision: D49521866 fbshipit-source-id: 8687df8799965479fae66e1e4733a97c1946cdb1
philIip
force-pushed
the
export-D49521866
branch
from
81f662a to
89cfe1f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 25, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: mdvacca Differential Revision: D49521866 fbshipit-source-id: 412ccbd8750b0f0e4194e30e718dd50adaf75725
philIip
force-pushed
the
export-D49521866
branch
from
89cfe1f to
e180f4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 27, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 6c37943d680c5c6d387b2a984f3fb2b4d421bcc0
philIip
force-pushed
the
export-D49521866
branch
from
e180f4e to
6bb1dd1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 2, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 3e3c2999a07db8faccdd38a85aaf859873fb4b5f
philIip
force-pushed
the
export-D49521866
branch
from
6bb1dd1 to
142db9f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 2, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 8637b1ea9967aa8ea8322dd05e570d44be02cf42
philIip
force-pushed
the
export-D49521866
branch
from
142db9f to
c00cbc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 4f92a3d5cbb536a2c0e5bce7dc33d9756c2511fe
philIip
force-pushed
the
export-D49521866
branch
from
c00cbc3 to
18ac72b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 0b141e89426f52faefa84f04712c698f6e71d7fc
philIip
force-pushed
the
export-D49521866
branch
from
18ac72b to
751a39b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 672a2077de0077c28303ffc80aaeedab750be388
philIip
force-pushed
the
export-D49521866
branch
from
751a39b to
3017b0f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 664e472d57792c6f84a33d19df3a3322abc06d56
philIip
force-pushed
the
export-D49521866
branch
from
3017b0f to
c20672d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 77a43eed4e7014c5de60e8cee6f0d6ae8e2a68ba
philIip
force-pushed
the
export-D49521866
branch
from
c20672d to
0d8a357
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 25158852bb24d8363c30ce42ba507a186df5470e
philIip
force-pushed
the
export-D49521866
branch
from
0d8a357 to
b0b9746
Compare
Differential Revision: D49521864 fbshipit-source-id: b059c0201f7de1330fc85b8f542613b9bd40903c
Differential Revision: D49521863 fbshipit-source-id: 75dec87b0210386b37cbee20b144f32ec6a1dc05
…lse (facebook#39591) Summary: Pull Request resolved: facebook#39591 Changelog: [Internal] I'm refactoring this for a couple of reasons: 1) it isolates the void execution path, which we are changing now 2) switch case is safer than if else, in the future if we introduce new return types Reviewed By: RSNara Differential Revision: D49521866 fbshipit-source-id: 3ef1458f308510be7a69b733099b70ae821e26df
|
This pull request was exported from Phabricator. Differential Revision: D49521866 |
philIip
force-pushed
the
export-D49521866
branch
from
b0b9746 to
78e42eb
Compare
|
This pull request has been merged in 113de6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
I'm refactoring this for a couple of reasons:
Differential Revision: D49521866