lift isSyncModule_ check outside of isMethodSync #39590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
Base commit: 4da0d44 |
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 21, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Differential Revision: D49521863 fbshipit-source-id: 22c41e3987719ebf15f1567ac03d12a76fa6e5f8
philIip
force-pushed
the
export-D49521863
branch
from
0892e98 to
9313991
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 25, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: mdvacca Differential Revision: D49521863 fbshipit-source-id: cc7cc8fd9bf239bce192c71781c0b740e2f24a2f
philIip
force-pushed
the
export-D49521863
branch
from
9313991 to
e70e798
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 25, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: mdvacca Differential Revision: D49521863 fbshipit-source-id: 4150c779b9f2cad7d9dae3de18fb495746d4556e
philIip
force-pushed
the
export-D49521863
branch
from
e70e798 to
f1225e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
force-pushed
the
export-D49521863
branch
from
f1225e0 to
86c605a
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Differential Revision: D49521863 fbshipit-source-id: 3275bbf63e0b8cf34e075fccc533bb09045ae4cc
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 2, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Differential Revision: D49521863 fbshipit-source-id: 93750f689150030c3b75f10c75244f532c51b466
philIip
force-pushed
the
export-D49521863
branch
from
86c605a to
12eb06a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 2, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Differential Revision: D49521863 fbshipit-source-id: 6731b3c4f9595402fd75e90cd039f369a767f02c
philIip
force-pushed
the
export-D49521863
branch
from
12eb06a to
c117c9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: javache Differential Revision: D49521863 fbshipit-source-id: 487a7a31149849dbfacb405ebf0614e93fee4824
philIip
force-pushed
the
export-D49521863
branch
from
c117c9a to
71a03cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: javache Differential Revision: D49521863 fbshipit-source-id: 4ad40507e7de25c9d40f31e7fc42d3a71edd29e8
philIip
force-pushed
the
export-D49521863
branch
from
71a03cc to
e0e2b05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: javache Differential Revision: D49521863 fbshipit-source-id: 385c353fadcf52dc6a463775ef24f9f921525901
philIip
force-pushed
the
export-D49521863
branch
from
e0e2b05 to
52bfdc0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: javache Differential Revision: D49521863 fbshipit-source-id: 19e988dd7059db5f9721aa36a7f376593143e6c9
philIip
force-pushed
the
export-D49521863
branch
from
52bfdc0 to
63b6d3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: javache Differential Revision: D49521863 fbshipit-source-id: 542e3d1aef9f76c6d14426ab086e5a58eb420559
philIip
force-pushed
the
export-D49521863
branch
from
63b6d3e to
cbcbfa9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Oct 3, 2023
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: javache Differential Revision: D49521863 fbshipit-source-id: ecba6c9e13b42c95d5074a14919d371420f9aee5
philIip
force-pushed
the
export-D49521863
branch
from
cbcbfa9 to
c2f910e
Compare
Differential Revision: D49521864 fbshipit-source-id: 2fd9225f680ea36e4818d66bcf51281ce5cf4e77
Summary: Pull Request resolved: facebook#39590 Changelog: [Internal] some cleanup! Reviewed By: javache Differential Revision: D49521863 fbshipit-source-id: b04146f35459bdcab61dcd8d3d6ba9ccac510ecf
|
This pull request was exported from Phabricator. Differential Revision: D49521863 |
philIip
force-pushed
the
export-D49521863
branch
from
c2f910e to
1ac1683
Compare
|
This pull request has been merged in 36a202b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
some cleanup!
Differential Revision: D49521863