Breaking: Remove YGConfigGetInstanceCount #39369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 6d6dfec415bef9d2fc37e4ac776dfe62868b4839
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: a3b6a5308571ac8d2332f6f55c5f5d8f1993a45b
NickGerleman
force-pushed
the
export-D49131207
branch
from
c129714
to
7227fee
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 243b3780e7a2fdf8b63ccdd67fc1b10b39198d67
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 3444bfe067cb0ac55b92952a3635ba2d8a4b8ae4
NickGerleman
force-pushed
the
export-D49131207
branch
from
7227fee
to
9b9ccac
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: f62a6d802f2da6ee6196043cdc16392d23ad67cb
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: f13348bc3ead322105c6a7dcfda167a9b13a821d
NickGerleman
force-pushed
the
export-D49131207
branch
from
9b9ccac
to
ba68066
Compare
Base commit: a2fb46e |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 80ae77ab6312a86eaa3046061406318d12a2d6c2
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 10, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 2c792751af5b31354a06ff3985040a73691b8009
NickGerleman
force-pushed
the
export-D49131207
branch
from
ba68066
to
711e4c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
force-pushed
the
export-D49131207
branch
from
711e4c1
to
5e869fc
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 11, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 4c66f4e0692ff579ce4d8ee38e2f1176977a766d
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 6e59be2a10d9de4c48ffc9174fd075d3075d1e53
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: fa732ba593e6d1bc97c0274a73b03626d25cd556
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 67f665ead7aa7690dc2a24a4c1a26b68841bee80
NickGerleman
force-pushed
the
export-D49131207
branch
from
5e869fc
to
30d757f
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 1e95a2e55076c5916d5df45e65ee873e7a7afe4a
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 160d2f0d33cfa224b495b811d0c526aa0be6b0de
NickGerleman
force-pushed
the
export-D49131207
branch
from
30d757f
to
9b8dc4a
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 80068755141b0c9e2bb005d336020d8783b4fb01
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: dac73b936f38071a838d2135d298706be11128bb
NickGerleman
force-pushed
the
export-D49131207
branch
from
9b8dc4a
to
b9688de
Compare
Summary: This changes public Yoga API to in more places accept const structures where before they required mutable ones. This tries to avoid more breaking changes yet, e.g. changing callbacks to require clients do not modify nodes when they are passed for logging. We also don't have const variants for returning child structures which would allow mutation of dependencies of the const object. These would need new names under the public API, since we do not have operator overloading in C. Differential Revision: D49130412 fbshipit-source-id: 734571a9d53cbef722178b2068e1045607a3abd7
Summary: X-link: facebook/yoga#1369 Pull Request resolved: facebook#39370 This fixes const-correctness of callbacks (e.g. not letting a logger function modify nodes during layout). This helps us to continue to fix const-correctness issues inside of Yoga. This change is breaking to the public API, since it requires a change in signature passed to Yoga. Changelog: [Internal] Differential Revision: https://internalfb.com/D49130714 fbshipit-source-id: 98e4189e2c7e594c8dfd3e0b5540d475ef0d5852
Summary: Yoga's public API exposes indices most often as `uint32_t`, with exception of clone callbacks which are `int32_t`. Yoga internally represents these indices as `size_t` when dealing with the child vector, and this is the true index. This changes the API to consistently be `size_t`. This should not be breaking for most users, but will cause breaks where: 1. Users set a clone node callback (I think this should be rare. RN uses it, but only because it relies on a separate private API). 2. Callers of `YGNodeGetChildCount()` are assigning to an int with less width than `size_t` and have strong warnings enabled. 3. Using a newer Yoga binary with older source, since we are not preserving ABI compatibility (Yoga in general does not aim to be ABI stable between major versions, only ABI safe for a given set of sources). Differential Revision: D49130914 fbshipit-source-id: 6b6725423ab3003fcc2fa7da0ba71ad440fe2f66
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 36cf4caebaba498a806c0aeea853b54f18077832
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 4e0f15068a10f95597e3421d3e7ad84d840eec94
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
force-pushed
the
export-D49131207
branch
from
b9688de
to
7618bdc
Compare
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1370 X-link: facebook/react-native#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 58537ed635ed455ff065471bdf77061a4bf826f4
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: #1370 X-link: facebook/react-native#39369 This was added in #497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 58537ed635ed455ff065471bdf77061a4bf826f4
|
This pull request has been merged in 8581732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree.
This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed.
Differential Revision: D49131207