Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ReactPackage as NullSafe #39316

Closed
wants to merge 1 commit into from
Closed

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 6, 2023

Summary:
Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Differential Revision: D48992474

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

@analysis-bot
Copy link

analysis-bot commented Sep 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,323,796 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,562,524 +22
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 59e6b11
Branch: main

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 6, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 7, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 11, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against d2ca26d

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 14, 2023
Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

Summary:

Marking ReactPackage as NullSafe as it has proper annotations

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48992474
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48992474

@github-actions
Copy link

This pull request was successfully merged by @mdvacca in a670824.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants