Implement clientWidth/clientHeight in ReadOnlyElement #39305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49008698 |
Base commit: 2608a37 |
|
This pull request was exported from Phabricator. Differential Revision: D49008698 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 6, 2023
Summary: Pull Request resolved: facebook#39305 This adds a new method in Fabric to get the inner size for an element (whole size excluding borders, which would be the scrollable size of the element), and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : `clientWidth`: width of the element excluding the size of the left and right border. `clientHeight`: height of the element excluding the size of the top and bottom border. If the element isn't displayed or it has display: inline, it return `0` in both cases. These APIs provided rounded integers. Changelog: [internal] Reviewed By: mdvacca Differential Revision: D49008698 fbshipit-source-id: ba08978bb19fc3b639fbe0f1bd478b2c9497cb5b
rubennorte
force-pushed
the
export-D49008698
branch
from
db82427 to
02fad1e
Compare
|
This maybe a typo |
|
This pull request was exported from Phabricator. Differential Revision: D49008698 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2023
Summary: Pull Request resolved: facebook#39305 This adds a new method in Fabric to get the inner size for an element (whole size excluding borders, which would be the scrollable size of the element), and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : `clientWidth`: width of the element excluding the size of the left and right border. `clientHeight`: height of the element excluding the size of the top and bottom border. If the element isn't displayed or it has display: inline, it return `0` in both cases. These APIs provided rounded integers. Changelog: [internal] Differential Revision: D49008698 fbshipit-source-id: a00851c55af21057bea228dee32be5175748b32f
rubennorte
force-pushed
the
export-D49008698
branch
from
02fad1e to
8b9f857
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49008698 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 7, 2023
Summary: Pull Request resolved: facebook#39305 This adds a new method in Fabric to get the inner size for an element (whole size excluding borders, which would be the scrollable size of the element), and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : `clientWidth`: width of the element excluding the size of the left and right border. `clientHeight`: height of the element excluding the size of the top and bottom border. If the element isn't displayed or it has display: inline, it return `0` in both cases. These APIs provided rounded integers. Changelog: [internal] Reviewed By: NickGerleman Differential Revision: D49008698 fbshipit-source-id: 46304d16a70acf1f2e5da7dd74cded0dc41e9710
rubennorte
force-pushed
the
export-D49008698
branch
from
8b9f857 to
41036c8
Compare
rubennorte
changed the title
Differential Revision: D48951824 fbshipit-source-id: b94b88af720ac95fc6fe5d5baf2bc2ede5e79ff7
Summary: Pull Request resolved: facebook#39305 This adds a new method in Fabric to get the inner size for an element (whole size excluding borders, which would be the scrollable size of the element), and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 : `clientWidth`: width of the element excluding the size of the left and right border. `clientHeight`: height of the element excluding the size of the top and bottom border. If the element isn't displayed or it has display: inline, it return `0` in both cases. These APIs provided rounded integers. Changelog: [internal] Reviewed By: NickGerleman Differential Revision: D49008698 fbshipit-source-id: e9fc54775f162809b026de23397df9cbe59d8d80
|
This pull request was exported from Phabricator. Differential Revision: D49008698 |
rubennorte
force-pushed
the
export-D49008698
branch
from
41036c8 to
e81a0a7
Compare
|
This pull request has been merged in f1e9a30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds a new method in Fabric to get the inner size for an element (whole size excluding borders, which would be the scrollable size of the element), and uses it to implement the following methods as defined in react-native-community/discussions-and-proposals#607 :
clientWidth: width of the element excluding the size of the left and right border.clientHeight: height of the element excluding the size of the top and bottom border.If the element isn't displayed or it has display: inline, it return
0in both cases.These APIs provided rounded integers.
Changelog: [internal]
Differential Revision: D49008698