Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch) #38359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 43826fa |
facebook-github-bot
added
the
Shared with Meta
fabOnReact
changed the title
fabOnReact
changed the title
Update 16/12/2023Re-based and re-tested (previous test here Expensify/App#17767 (comment)) before 
after 
|
|
CI failures are caused by CI configs. They are not related to the changes in the PR. |
|
CI Failure not related to PR |
|
Hello @dmytrorykun. How can I help to get this PR merged? Thanks a lot |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Jan 18, 2024
|
@dmytrorykun merged this pull request in 349d550. |
|
@fabOnReact Jumping in real quick to say thanks for this one! |
|
@fabOnReact @dmytrorykun @cipolleschi this caused a change when merged which broke the RNTester UI test we have for lineheight style on multiline textinput, for iOS Paper. Before/after 
References:
From the description it looks like this change was replicating some logic from Fabric, but now in this example, we renderer differently between old arch and new arch? Do we know why the RNTester textStyles example rendering is now different between the two, and if one of these has an issue? I'm going to assign this failure to @dmytrorykun internally to follow up, and either update screenshots, or pursue a fix. |
lunaleaps
pushed a commit
that referenced
this pull request
Feb 20, 2024
…iOS without changing Text baseline (Paper - old arch) (#38359) Summary: This PR fixes visual regression introduced with #37465 (comment) Adding paragraphStyle.maximumLineHeight to a iOS UITextField displays the text under the UITextField ([ios-screenshot-1][1], [ios-screenshot-2][2], [ios-screenshot-3][3]). The PR implements the logic from RCTTextShadowView [#postprocessAttributedText](https://github.com/facebook/react-native/blob/9ab27e8895d6934e72ebdc601d169578ab9628f1/packages/react-native/Libraries/Text/Text/RCTTextShadowView.m#L165-L167) in RCTBaseTextInpuShadowView [#uiManagerWillPerformMounting](https://github.com/facebook/react-native/blob/4c944540f732c6055d447ecaf37d5c8f3eec1bc4/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputShadowView.m#L130-L192). [1]: https://user-images.githubusercontent.com/24992535/238834159-566f7eef-ea2d-4fd4-a519-099b0a12046c.png "ios-screenshot-1" [2]: https://user-images.githubusercontent.com/24992535/238834184-feb454a9-6504-4832-aec8-989f1d027861.png "ios-screenshot-2" [3]: https://user-images.githubusercontent.com/24992535/238834283-cf572f94-a641-4790-92bf-bbe43afb1443.png "ios-screenshot-3" [4]: https://github.com/Expensify/App/assets/24992535/06726b45-7e35-4003-9fcc-50c8d0dff0f6 [5]: https://github.com/Expensify/App/assets/24992535/d9745d29-8863-4170-bcc3-e78fa7e550d2 fixes #28012 fixes #33986 Related #35741 #31112 ## Changelog: [IOS] [FIXED] - Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch) Pull Request resolved: #38359 Test Plan: Extensive test included in the PR comments #37465 (comment) and Expensify/App#17767 (comment) Reviewed By: cipolleschi Differential Revision: D52325261 Pulled By: dmytrorykun fbshipit-source-id: d072a598bfaafbbffc41005b1fda1795cf3d8ab9
This was referenced Feb 29, 2024
fabOnReact
added a commit
to fabOnReact/react-native-live-markdown
that referenced
this pull request
May 19, 2024
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes visual regression introduced with #37465 (comment). Detailed explanation available in the summary of PR #37465.
Adding paragraphStyle.maximumLineHeight to a iOS UITextField displays the text under the UITextField (ios-screenshot-1, ios-screenshot-2, ios-screenshot-3).
The PR implements the logic from RCTTextShadowView #postprocessAttributedText in RCTBaseTextInpuShadowView #uiManagerWillPerformMounting.
fixes #28012 fixes #33986 fixes Expensify/App#15640
Related #35741 #31112
Changelog:
[IOS] [FIXED] - Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch)
Test Plan:
Extensive test included in the PR comments #37465 (comment) and Expensify/App#17767 (comment)