Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RCTSurfaceHostingComponent and RCTSurfaceBackedComponent (#38183) #38213

Closed

Conversation

constantine-fry
Copy link
Contributor

Summary:

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Differential Revision: D47255482

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jul 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

@analysis-bot
Copy link

analysis-bot commented Jul 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,836,352 -1
android hermes armeabi-v7a 8,146,238 +1
android hermes x86 9,341,719 -4
android hermes x86_64 9,184,459 -2
android jsc arm64-v8a 9,448,286 +2
android jsc armeabi-v7a 8,630,039 +0
android jsc x86 9,530,965 -1
android jsc x86_64 9,774,159 -1

Base commit: ff1972d
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 6, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Differential Revision: D47255482

fbshipit-source-id: 933c40e269463f44e543df48987e13a9689c5c32
constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 6, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Differential Revision: D47255482

fbshipit-source-id: 09a7f64b09d11a452354b4414f7d0394f089e4a3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 6, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 1f260d4b4a6d0228082ff471eddafcd9ab7f8d05
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 6, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 33c6278649e0f4c8c82f316e400df3ddb613134f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 6, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 47fe2967bf28a8009b4dbaa82d988594b62648a3
constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 7, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 5f604f04fe0f254c4b18600bfeb2e9d873378256
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 7, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 7a7f5c9c2f13e476457156e3027608f50a0f473f
constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 7, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 46837088fd4e3e307fdb2a70d08bd8bb85130682
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 10, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: f50ac3e2aada9f14ac6e2e33d974ddc6c5f8443e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 10, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 5329461c4cc1a0d324076e580c369fb30b342ac7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 11, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: eab7a956c99f5701390105b19855abda159ee111
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 12, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 4b437f67f4cedc4225f9243445b87a6e0a22a325
constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 12, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: dfb3fd7ae1cad35ec266d64e3bbb91cb0b7cd3f5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 17, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 4b715f4c1bf849d87c0afe7ab157c06624d43c47
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

constantine-fry added a commit to constantine-fry/react-native that referenced this pull request Jul 18, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 83321f46ad8bd5f5e748331975306c4876f425cb
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: d9fd73ab8fd811821b15b4864373884aa879488a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D47255482

@github-actions
Copy link

This pull request was successfully merged by @constantine-fry in b8d60a8.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jul 18, 2023
juniorklawa pushed a commit to juniorklawa/react-native that referenced this pull request Jul 20, 2023
…ok#38213)

Summary:
Pull Request resolved: facebook#38213

Pull Request resolved: facebook#38183

Changelog: [iOS][Removed] Remove RCTSurfaceHostingComponent and RCTSurfaceBackedComponent, needed only for ComponentKit integration.

Reviewed By: motiz88

Differential Revision: D47255482

fbshipit-source-id: 11db6f37a69a6f1e76ee7744a92f85c232342bd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants