Bump NDK to 25 #37974

szymonrybczak · 2023-06-20T13:17:18Z

Summary:

Bumps NDK to current LTS Release.

Changelog:

[Android] [Changed] - Bump NDK to 25

Test Plan:

CI Green ✅

szymonrybczak · 2023-06-20T13:27:31Z

Looks like CircleCI's machine broke on installing dependencies on iOS 🥲

cortinico

That's sadly not sufficient :(
First I'd like to wait for this to land:

AGP to 8.0.2 #37019

Then we'll have to make sure all the dependencies we link against are built with NDK 25. Namely:

FBJNI
Hermes
Flipper

Your change is only bumping the NDK version of the template. We'll have to take care of the NDK version of ReactAndroid as well. Would you be able to take a look at it?

analysis-bot · 2023-06-20T13:44:28Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,889,374	+46,093
android	hermes	armeabi-v7a	7,939,885	-212,536
android	hermes	x86	9,287,256	-61,791
android	hermes	x86_64	9,191,068	-733
android	jsc	arm64-v8a	9,478,667	+22,655
android	jsc	armeabi-v7a	8,421,751	-215,392
android	jsc	x86	9,462,239	-76,855
android	jsc	x86_64	9,779,136	-3,251

Base commit: d3c28d2
Branch: main

szymonrybczak · 2023-06-20T14:20:31Z

@cortinico Yeah, so:
FBJNI - 23.1.7779620
Hermes - Not sure, where to find it.
Flipper - 25.1.8937393
I can create PRs bumping versions in those repositories.
Yes, I can look at ReactAndroid, is just doing that - will be okay in build.gradle.kts?

val ndkVersion by extra(System.getenv("ANDROID_NDK_VERSION") ?: "25.2.9519653")

Also I think we can bump NDK version in the docker-android, WDYT?

cortinico · 2023-06-20T14:23:28Z

FBJNI - 23.1.7779620

I'm currently working on it. Will be out with FBJNI version 0.5.0 sometime soon

Hermes - Not sure, where to find it.

This is controlled by ReactAndroid/hermes-engine/build.gradle so it will be bumped with everything.

Flipper - 25.1.8937393

That's correct as that's the version we want to use actually (see https://developer.android.com/build/releases/gradle-plugin#compatibility-8-0-0 as the default for 8.0.0).

We'll have to find which version of Flipper is the first one that bumped NDK to 25 and make sure we use it.

cortinico · 2023-06-20T14:23:52Z

Also I think we can bump NDK version in the docker-android, WDYT?

Yup that's also needed 🙏

szymonrybczak · 2023-06-20T14:49:29Z

We'll have to find which version of Flipper is the first one that bumped NDK to 25 and make sure we use it.

It was bumped in this PR facebook/flipper#4443, and it was first released in 0.187.1, btw. just out of curiosity why the first one?

Yup that's also needed 🙏

PR: react-native-community/docker-android#204

cortinico · 2023-06-20T15:24:16Z

and it was first released in 0.187.1, btw. just out of curiosity why the first one?

Because we might already have it shipped/bumped, but that's not the case as we're on 0.182.0

cortinico · 2023-07-07T09:32:55Z

@szymonrybczak can we move this forward?

szymonrybczak · 2023-07-07T10:30:20Z

Yeah, sure. So I updated the version to 25.1.8937393 (as it is the default for 8.0.0) in template and also in ReactAndroid. And I check the status of bumping to NDK 25 inside dependencies, and it looks like this:
FBJNI - Bumped, but not released yet.
Flipper - Not bumped in RN repository.
docker-android - Bumped, but not released yet.

cortinico · 2023-07-07T17:25:13Z

FBJNI - Bumped, but not released yet.
docker-android - Bumped, but not released yet.

I will take of those two next week.

Flipper - Not bumped in RN repository.

@szymonrybczak do you want to attempt to do this bump? It should be fairly easy (just search for a previous Flipper bump) 👍 I can support if needed

Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](#37974) for more context. ## Changelog: [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: #38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c

Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context. ## Changelog: [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: facebook#38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c

cortinico · 2023-07-24T10:07:13Z

Hey @szymonrybczak
Sorry this took longer for me, but now we should be fully unblocked:

https://github.com/facebookincubator/fbjni/releases/tag/v0.5.0
https://github.com/react-native-community/docker-android/releases/tag/v10.0

Can I ask you to bump those 2 and rebase? And we should be able to import this 👍

github-actions · 2023-07-24T12:56:30Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against cc92bcc

facebook-github-bot · 2023-07-25T11:46:30Z

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2023-07-26T02:32:11Z

@cortinico merged this pull request in 28deaa3.

Summary: Bumps NDK to current LTS Release. ## Changelog: [Android] [Changed] - Bump NDK to 25 Pull Request resolved: facebook#37974 Test Plan: CI Green ✅ Reviewed By: christophpurrer Differential Revision: D47754763 Pulled By: cortinico fbshipit-source-id: 24fbca503b3814c28a05aada5223c741e14bda28

Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context. [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: facebook#38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c

Summary: Bumps NDK to current LTS Release. [Android] [Changed] - Bump NDK to 25 Pull Request resolved: facebook#37974 Test Plan: CI Green ✅ Reviewed By: christophpurrer Differential Revision: D47754763 Pulled By: cortinico fbshipit-source-id: 24fbca503b3814c28a05aada5223c741e14bda28

Summary: Bumped Flipper version from `0.182.0` to `0.201.0` (which is currently latest version). New version contain NDK 25, which is necessarily for us since we would like to bump NDK in React Native to 25, see [here](facebook#37974) for more context. [General] [Changed] - Bump Flipper to 0.204.0 Pull Request resolved: facebook#38260 Test Plan: CI Green ✅ Reviewed By: NickGerleman, mdvacca Differential Revision: D47373525 Pulled By: cortinico fbshipit-source-id: d1d5f03cb2f00bc8b9064af986b7c3b6e7ccae3c

Summary: Bumps NDK to current LTS Release. [Android] [Changed] - Bump NDK to 25 Pull Request resolved: facebook#37974 Test Plan: CI Green ✅ Reviewed By: christophpurrer Differential Revision: D47754763 Pulled By: cortinico fbshipit-source-id: 24fbca503b3814c28a05aada5223c741e14bda28

Summary: Bumps NDK to current LTS Release. ## Changelog: [Android] [Changed] - Bump NDK to 25 Pull Request resolved: facebook/react-native#37974 Test Plan: CI Green ✅ Reviewed By: christophpurrer Differential Revision: D47754763 Pulled By: cortinico fbshipit-source-id: 24fbca503b3814c28a05aada5223c741e14bda28 Original: facebook/react-native@28deaa3

Summary: Bumps NDK to current LTS Release. ## Changelog: [Android] [Changed] - Bump NDK to 25 Pull Request resolved: facebook/react-native#37974 Test Plan: CI Green ✅ Reviewed By: christophpurrer Differential Revision: D47754763 Pulled By: cortinico fbshipit-source-id: 24fbca503b3814c28a05aada5223c741e14bda28 Original-Commit: facebook/react-native@28deaa3

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2023

cortinico requested changes Jun 20, 2023

View reviewed changes

szymonrybczak force-pushed the bump/ndk-version branch from e23d9db to f21c771 Compare July 7, 2023 10:29

szymonrybczak force-pushed the bump/ndk-version branch from f21c771 to 1fd6a10 Compare July 7, 2023 10:45

cortinico mentioned this pull request Jul 7, 2023

Build React Native Shared Objects with Stack Smash Protection #38018

Closed

szymonrybczak mentioned this pull request Jul 9, 2023

Bump Flipper to 0.201.0 #38260

Closed

cortinico mentioned this pull request Jul 19, 2023

React Native 0.71.3 generates .so files that are not stack canary protected #36870

Closed

Bump NDK to 25

d60b3f9

szymonrybczak force-pushed the bump/ndk-version branch 2 times, most recently from 1b69f60 to 7d68762 Compare July 24, 2023 12:55

szymonrybczak force-pushed the bump/ndk-version branch from 7d68762 to 4d8ea1f Compare July 24, 2023 13:06

szymonrybczak added 2 commits July 24, 2023 18:02

Bump FBJNI version.

1a86fc9

Bump docker image version.

cc92bcc

szymonrybczak force-pushed the bump/ndk-version branch from 4d8ea1f to cc92bcc Compare July 24, 2023 16:03

facebook-github-bot closed this in 28deaa3 Jul 26, 2023

facebook-github-bot added the Merged This PR has been merged. label Jul 26, 2023

szymonrybczak deleted the bump/ndk-version branch July 26, 2023 10:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump NDK to 25 #37974

Bump NDK to 25 #37974

szymonrybczak commented Jun 20, 2023

szymonrybczak commented Jun 20, 2023

cortinico left a comment

analysis-bot commented Jun 20, 2023 •

edited

Loading

szymonrybczak commented Jun 20, 2023

cortinico commented Jun 20, 2023

cortinico commented Jun 20, 2023

szymonrybczak commented Jun 20, 2023

cortinico commented Jun 20, 2023

cortinico commented Jul 7, 2023

szymonrybczak commented Jul 7, 2023

cortinico commented Jul 7, 2023

cortinico commented Jul 24, 2023

github-actions bot commented Jul 24, 2023 •

edited

Loading

facebook-github-bot commented Jul 25, 2023

facebook-github-bot commented Jul 26, 2023

Bump NDK to 25 #37974

Bump NDK to 25 #37974

Conversation

szymonrybczak commented Jun 20, 2023

Summary:

Changelog:

Test Plan:

szymonrybczak commented Jun 20, 2023

cortinico left a comment

Choose a reason for hiding this comment

analysis-bot commented Jun 20, 2023 • edited Loading

szymonrybczak commented Jun 20, 2023

cortinico commented Jun 20, 2023

cortinico commented Jun 20, 2023

szymonrybczak commented Jun 20, 2023

cortinico commented Jun 20, 2023

cortinico commented Jul 7, 2023

szymonrybczak commented Jul 7, 2023

cortinico commented Jul 7, 2023

cortinico commented Jul 24, 2023

github-actions bot commented Jul 24, 2023 • edited Loading

facebook-github-bot commented Jul 25, 2023

facebook-github-bot commented Jul 26, 2023

analysis-bot commented Jun 20, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited

Loading