New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component type references in xplat #37903

Closed

pieterv wants to merge 1 commit into facebook:main from pieterv:export-D46748791

Member

pieterv commented Jun 15, 2023

Differential Revision: D46748791

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

github-actions bot commented Jun 15, 2023 •

edited

Loading

	Fails
🚫	❔ This pull request needs a description.

Generated by 🚫 dangerJS against d542f00

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46748791

1 similar comment

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46748791

pieterv added a commit to pieterv/react-native that referenced this pull request


          Fix component type references in xplat (facebook#37903)

70b3b03

Summary:
Pull Request resolved: facebook#37903

The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files.

Reviewed By: gkz

Differential Revision: D46748791

fbshipit-source-id: 446c3e752e3d3841e2ce7649c7eae61ebd468e14

pieterv force-pushed the export-D46748791 branch from 8130528 to 70b3b03 Compare

June 15, 2023 01:18

pieterv added a commit to pieterv/react-native that referenced this pull request


          Fix component type references in xplat (facebook#37903)

7d5d24b

Summary:
Pull Request resolved: facebook#37903

The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files.

Changelog: [Internal]

Reviewed By: gkz

Differential Revision: D46748791

fbshipit-source-id: 76e304aca202f627b4b51fff7607ca5b9fa28b61

pieterv force-pushed the export-D46748791 branch from 70b3b03 to 7d5d24b Compare

June 15, 2023 01:29

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46748791

pieterv added a commit to pieterv/react-native that referenced this pull request


          Fix component type references in xplat (facebook#37903)

51a9765

Summary:
Pull Request resolved: facebook#37903

The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files.

Changelog: [Internal]

Reviewed By: gkz

Differential Revision: D46748791

fbshipit-source-id: 3a5d36ebd59707b8c4786c95066a5ec6337a9bea

pieterv force-pushed the export-D46748791 branch from 7d5d24b to 51a9765 Compare

June 15, 2023 01:38

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46748791

analysis-bot commented Jun 15, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,757,680	-4
android	hermes	armeabi-v7a	8,070,256	-2
android	hermes	x86	9,250,277	-4
android	hermes	x86_64	9,099,413	-5
android	jsc	arm64-v8a	9,318,828	-4
android	jsc	armeabi-v7a	8,508,735	-5
android	jsc	x86	9,382,316	-4
android	jsc	x86_64	9,635,564	-4

Base commit: 8c9e375
Branch: main

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46748791

pieterv added a commit to pieterv/react-native that referenced this pull request


          Fix component type references in xplat (facebook#37903)

Summary:
Pull Request resolved: facebook#37903

The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files.

Changelog: [Internal]

Reviewed By: gkz

Differential Revision: D46748791

fbshipit-source-id: 0300ce24dabc7d36335354e667ec50fc1c7127cb

pieterv force-pushed the export-D46748791 branch from 51a9765 to 7748927 Compare

June 15, 2023 02:50

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46748791

pieterv added a commit to pieterv/react-native that referenced this pull request


          Fix component type references in xplat (facebook#37903)

f64f8db

Summary:
Pull Request resolved: facebook#37903

The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files.

Changelog: [Internal]

Reviewed By: gkz

Differential Revision: D46748791

fbshipit-source-id: 439a6b6a3e1f9eec5d661bbfb2cb3c630c0ea49c

pieterv force-pushed the export-D46748791 branch from 7748927 to f64f8db Compare

June 15, 2023 04:15


          Fix component type references in xplat (facebook#37903)

d542f00

Summary:
Pull Request resolved: facebook#37903

The name "component" in a function type contexts will be banned in future versions of Flow (the same other keywords like typeof are today). This diff renames the offending usages in xplat files.

Changelog: [Internal]

Reviewed By: gkz

Differential Revision: D46748791

fbshipit-source-id: 65994bc97d4930406b5e0b6a286d7fe08be8ff4a

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request was exported from Phabricator. Differential Revision: D46748791

pieterv force-pushed the export-D46748791 branch from f64f8db to d542f00 Compare

June 15, 2023 04:22

facebook-github-bot closed this in

894b62c

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Jun 15, 2023

This pull request has been merged in 894b62c.

adamaveray added a commit to adamaveray/react-native that referenced this pull request


          Merge branch 'main' into feature/automaticKeyboardInsetsImprovements

9d7205f

* main: (135 commits)
  translation auto-update for i18n/twilight.config.json on master
  Interop: Introduce Bridge proxy
  Remove okhttp internal util usage (facebook#37843)
  Update debian to fix CI while updating Node (facebook#37841)
  fix: foreground ripple crash on api < 23 (facebook#37901)
  Re-add the top level LICENSE file (facebook#37916)
  Deploy 0.209.0 to xplat (facebook#37921)
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914)
  add emitObjectProp in parser primitives (facebook#37904)
  Make React-utils its own pod (facebook#37659)
  feat: allow custom assignment of rootView to rootViewController (facebook#37873)
  Switch xplat prettier config to hermes plugin (facebook#37915)
  Set iOS AppState to inactive when app is launching (facebook#37690)
  Use `fileExists` in replace_hermes script (facebook#37911)
  (docs): fix license url (facebook#37909)
  Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+
  Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874)
  Fix component type references in xplat (facebook#37903)
  Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867)
  test runtime lifecycle callback (facebook#37897)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner