Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W3CPointerEvents: fix NPE due to missing eventCoords #37761

Closed
wants to merge 1 commit into from
Closed

W3CPointerEvents: fix NPE due to missing eventCoords #37761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...t-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/JSPointerDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,10 @@ private MotionEvent convertMotionToRootFrame(View childView, MotionEvent childMo

private void updatePreviousStateFromEvent(MotionEvent event, PointerEventState eventState) {
// Caching the event state so we have a new "last"
mLastHitPathByPointerId = eventState.getHitPathByPointerId();
mLastEventCoordinatesByPointerId = eventState.getEventCoordinatesByPointerId();
// note: we need to make copies here as the eventState may be accessed later and we don't want
// mutations of these instance vars to affect it
mLastHitPathByPointerId = new HashMap<>(eventState.getHitPathByPointerId());
mLastEventCoordinatesByPointerId = new HashMap<>(eventState.getEventCoordinatesByPointerId());
mLastButtonState = event.getButtonState();

// Clean up any stale pointerIds
Expand Down