W3CPointerEvents: change click event from direct to bubbling #37539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45745906 |
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
May 24, 2023
…k#37539) Summary: Pull Request resolved: facebook#37539 AFAICT this was added in facebook#24359 to support accessibility, however per [the spec](https://www.w3.org/TR/uievents/#event-type-click) the click event is supposed to bubble up. This change updates the necessary configs so that `click` is treated as a bubbling event and not as a direct-dispatch event. Changelog: [Android] [Breaking] - W3CPointerEvents: change click event from direct to bubbling Reviewed By: yungsters Differential Revision: D45745906 fbshipit-source-id: 3c23d4ec82570e43eefd7295d301601396962ef0
|
This pull request was exported from Phabricator. Differential Revision: D45745906 |
Base commit: bdeb09b |
adanoff
pushed a commit
to adanoff/react-native
that referenced
this pull request
May 25, 2023
…k#37539) Summary: Pull Request resolved: facebook#37539 AFAICT this was added in facebook#24359 to support accessibility, however per [the spec](https://www.w3.org/TR/uievents/#event-type-click) the click event is supposed to bubble up. This change updates the necessary configs so that `click` is treated as a bubbling event and not as a direct-dispatch event. Changelog: [Android] [Breaking] - W3CPointerEvents: change click event from direct to bubbling Reviewed By: yungsters Differential Revision: D45745906 fbshipit-source-id: 94ea6c5a84120f35a4fa6044b08462b0cb1a77e7
|
This pull request was exported from Phabricator. Differential Revision: D45745906 |
…k#37539) Summary: Pull Request resolved: facebook#37539 AFAICT this was added in facebook#24359 to support accessibility, however per [the spec](https://www.w3.org/TR/uievents/#event-type-click) the click event is supposed to bubble up. This change updates the necessary configs so that `click` is treated as a bubbling event and not as a direct-dispatch event. Changelog: [Android] [Breaking] - W3CPointerEvents: change click event from direct to bubbling Reviewed By: yungsters Differential Revision: D45745906 fbshipit-source-id: 62ed0c8811bc6665ca7ba663d8aedeab68b17a44
|
This pull request was exported from Phabricator. Differential Revision: D45745906 |
|
This pull request has been merged in 61eb9b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
AFAICT this was added in #24359 to support accessibility, however per the spec the click event is supposed to bubble up.
This change updates the necessary configs so that
clickis treated as a bubbling event and not as a direct-dispatch event.Changelog: [Android] [Breaking] - W3CPointerEvents: change click event from direct to bubbling
Reviewed By: yungsters
Differential Revision: D45745906